Update doctest for tzdata 2025a release (fix the build)#163
Open
mattwynne wants to merge 1 commit intolau:masterfrom
Open
Update doctest for tzdata 2025a release (fix the build)#163mattwynne wants to merge 1 commit intolau:masterfrom
mattwynne wants to merge 1 commit intolau:masterfrom
Conversation
The doctest for Tzdata.periods/1 had hardcoded timezone data values from the 2024b release. When the library was upgraded to 2025a, the historical LMT data for Europe/Madrid was refined, causing the test to fail. Updated the doctest to reflect the correct values from the 2025a release. Licensing: This contribution is made by employees of Mechanical Orchard, Inc. under the terms of the project's license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The doctest for Tzdata.periods/1 had hardcoded timezone data values from the 2024b release. When the library was upgraded to 2025a, the historical LMT data for Europe/Madrid was refined, causing the test to fail. Updated the doctest to reflect the correct values from the 2025a release.
This gets the tests back to green.
Licensing: This contribution is made by employees of Mechanical Orchard, Inc. under the terms of the project's license.