feat: Update contract tests to support multiple synchronizers and initializers#222
Merged
kinyoklion merged 2 commits intomainfrom Feb 9, 2026
Merged
Conversation
…tializers Update the contract test implementation to use array-based synchronizers instead of Primary/Secondary structure to match the sdk-test-harness changes that add support for multiple synchronizers. Changes: - Change SdkConfigDataSystemParams.Synchronizers from SdkConfigSynchronizersParams to SdkConfigDataSynchronizerParams[] (array) - Remove SdkConfigSynchronizersParams class (Primary/Secondary structure) - Rename SdkConfigSynchronizerParams to SdkConfigDataSynchronizerParams - Update SdkClientEntity to iterate over synchronizers array Co-Authored-By: rlamb@launchdarkly.com <rlamb@launchdarkly.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
kinyoklion
approved these changes
Feb 6, 2026
Replace feat/fdv2 branch reference with v3.0.0-alpha.3 tag for the sdk-test-harness used in FDv2 contract tests. Co-Authored-By: rlamb@launchdarkly.com <rlamb@launchdarkly.com>
tanderson-ld
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore: Update contract tests to support multiple synchronizers and initializers
END_COMMIT_OVERRIDE
Requirements
Related issues
Related to sdk-test-harness commit: launchdarkly/sdk-test-harness@01a245c
Describe the solution you've provided
Updates the contract test implementation to match the sdk-test-harness changes that add support for multiple synchronizers (more than 2) for testing fallback scenarios.
Contract test model changes:
SdkConfigDataSystemParams.SynchronizersfromSdkConfigSynchronizersParams(withPrimary/Secondaryproperties) toSdkConfigDataSynchronizerParams[](array)SdkConfigSynchronizersParamsclassSdkConfigSynchronizerParamstoSdkConfigDataSynchronizerParamsfor consistencySdkClientEntity.BuildSdkConfigto iterate over the synchronizers arrayCI config change:
v3.0.0-alpha.3tag of sdk-test-harness instead of thefeat/fdv2branchHuman review checklist
v3.0.0-alpha.3tag exists in sdk-test-harness and is compatible with the array-based synchronizer format used hereDescribe alternatives you've considered
Could have kept backward compatibility by supporting both the old Primary/Secondary structure and the new array format, but this would add unnecessary complexity since the test harness has moved to the array-based approach.
Additional context
This is a contract test and CI config change only — no changes to the SDK itself.
Note
Medium Risk
Moderate risk due to a breaking change in the contract-test config model (
Synchronizersshape) and updated fallback-selection behavior that could alter FDv2/FDv1 test execution, though it is confined to test/CI code.Overview
Updates the contract test data-system configuration model to support multiple synchronizers by changing
SdkConfigDataSystemParams.Synchronizersfrom aPrimary/Secondaryobject to an array ofSdkConfigDataSynchronizerParams(and removing/renaming the old types).Adjusts
SdkClientEntity.BuildSdkConfigto build all provided synchronizers, and changes FDv1 fallback selection to pick the first polling synchronizer found (otherwise the first synchronizer). CI’s FDv2 contract test action is also updated to runsdk-test-harnessfrom the pinnedv3.0.0-alpha.3tag instead of thefeat/fdv2branch.Written by Cursor Bugbot for commit 349d410. This will update automatically on new commits. Configure here.