feat: Add DataSourceUpdateSink for client-side FDv2#1157
Draft
kinyoklion wants to merge 2 commits intomainfrom
Draft
feat: Add DataSourceUpdateSink for client-side FDv2#1157kinyoklion wants to merge 2 commits intomainfrom
kinyoklion wants to merge 2 commits intomainfrom
Conversation
Implements SDK-1921 (FDCS-06): the update sink that processes FDv2 ChangeSetResult payloads from the orchestrator and applies them to FlagManager. Handles full payloads (init), partial payloads (upsert per flag), and none payloads. Manages the selector (basis state) in memory only (Req 6.2.1) and tracks environmentId from response headers.
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
Moves selector and environmentId management into FlagManager, following the server SDK's LDTransactionalFeatureStore.applyChanges pattern. FlagManager.applyChanges accepts pre-converted ItemDescriptors with basis flag, selector, and environmentId. DataSourceUpdateSink simplified to a thin adapter that converts FDv2 protocol types and delegates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.