Open
Conversation
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
sdk-1910
Describe the solution you've provided
added the test
Additional context
I deviated a bit from the specs and read the flag value from the UI. I think we should update the specs to include this as a way to verify.
Note
Medium Risk
Changes CI behavior and introduces a new job that pulls secrets via OIDC/AWS SSM and runs browser automation, which can add flakiness and requires correct permissions/configuration.
Overview
Adds a lightweight Playwright e2e smoke test for
@launchdarkly/browser-examplethat loads the built static page and asserts the UI reports the boolean flag evaluates to true.Updates the
sdk/browserGitHub Actions workflow to run nightly on a cron schedule and introduces a newrun-examplejob that fetches LaunchDarkly keys from AWS SSM, builds the example, installs Chromium, and executes the new Playwright tests (while skipping the existing browser build/test matrix on scheduled runs).Written by Cursor Bugbot for commit b6e0f3c. This will update automatically on new commits. Configure here.