A few fixes for cudss #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Commented out dual_obj_val, primdual_int, rel_kkt_error fields - These fields are from upstream but not present in im/cudss-rebased C code - Kept restart-related fields (restart, total_integral, prim_normalized, etc.)
- Added cuda-direct solver type testing alongside cuda-indirect - Follows same pattern as mkl-direct and mkl-indirect - Both use same tolerances: atol=1e-2, rtol=1e-3, decimal_tol=2 - Tests now verify both CUDA indirect and direct (cuDSS) solvers
bstellato
changed the base branch from
develop-restarts-fixed
to
develop-restarts
imciner2
reviewed
Dec 2, 2025
The adaptive_rho_fraction field was removed from OSQPSettings in the develop-halpern branch of OSQP. Comment out the binding to fix CI build failures.
Collaborator
Author
|
I am going to merge since all tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.