feat: BIFUpdateSbi and remaining instances in InstancesUpdates.lean - #649
Merged
Conversation
2 tasks
alvinylt
commented
Aug 15, 2026
MackieLoeffel
left a comment
MackieLoeffel
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR! I only have some small comments.
MackieLoeffel
approved these changes
Aug 18, 2026
MackieLoeffel
left a comment
MackieLoeffel
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, looks great to me! I made a pass to unify the naming of siPure and siEmpValid. I also added a TODO, but that can be resolved in the future.
Collaborator
|
Thanks, looks good to me! Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #255 in full. Addresses #280 in part.
The type class instances
fromForall_fupdandfromForall_stepFupdare ported using the type classBIFUpdateSbi, which is in turn defined in terms of<si_pure>.Other Changes
Bug fixes for the instances
forall_plainandexists_plain: it is possible forAto be of typeSort 0.Checklist
authorssection of any appropriate files