Skip to content

feat: port Atomic - #665

Open
markusdemedeiros wants to merge 9 commits into
masterfrom
port-atomic
Open

feat: port Atomic#665
markusdemedeiros wants to merge 9 commits into
masterfrom
port-atomic

Conversation

@markusdemedeiros

@markusdemedeiros markusdemedeiros commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Description

Depends on #659, merge that first

I am very unsure about the notations section. It more or less has to be written for the files depending on this, but I am not confident in my ability to review the generated code. Please be extra critical of this section.

Checklist

  • My code follows the mathlib naming and code style conventions
  • I have added my name to the authors section of any appropriate files

Generative AI Guidelines

AI assistance is permitted when making contributions to Iris-Lean, however, generative AI systems tend to produce code which takes a long time to review.
Please carefully review your code to ensure it meets the following standards.

  • Your PR should avoid duplicating constructions found in Iris-Lean or in the Lean standard library.
  • have statements that do not aid readability or code reuse should be inlined.
  • Your proofs should be shortened such that their overall structure is explicable to a human reader. As a goal, aim to express one idea per line.
  • In general, proofs should not perform substantially more case splitting than their Rocq counterparts.

In our experience, a good place to begin refactoring is by re-arranging and combining independent tactic invocations.
We also find that pointing generative AI systems to the Mathlib code style guidelines can help them perform some of this refactoring work.

@markusdemedeiros
markusdemedeiros marked this pull request as ready for review August 18, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants