[Merged by Bors] - doc: fix the docstring of IsTopologicalTorsor#41780
[Merged by Bors] - doc: fix the docstring of IsTopologicalTorsor#41780gasparattila wants to merge 1 commit into
IsTopologicalTorsor#41780Conversation
The docstring incorrectly refers to `+ᵥ` and `-ᵥ` instead of their multiplicative versions.
|
easy |
PR summary f3035c0fdfImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
| /-- A topological torsor over a topological group is a torsor where `•` and `/ₛ` are continuous. -/ | ||
| @[to_additive] |
There was a problem hiding this comment.
@gasparattila okay, but please also include the docstring for the additive versions in the to_additive bit, like so:
| /-- A topological torsor over a topological group is a torsor where `•` and `/ₛ` are continuous. -/ | |
| @[to_additive] | |
| /-- A topological torsor over a topological group is a torsor where `•` and `/ₛ` are continuous. -/ | |
| @[to_additive /-- A topological additive torsor over a topological additive group is a torsor | |
| where `+ᵥ` and `-ᵥ` are continuous. -/] |
I'll just add this for now and merge it, but I wanted to point out that we should have both.
There was a problem hiding this comment.
@j-loreaux IsTopologicalAddTorsor is defined above, it already has a docstring
There was a problem hiding this comment.
@j-loreaux I've undone your change, since it would unnecessarily overwrite the existing docstring. I've also made #41883 to warn in this kind of situation.
6eefc0f to
f3035c0
Compare
|
As this PR is labelled bors merge |
The docstring incorrectly refers to `+ᵥ` and `-ᵥ` instead of their multiplicative versions.
|
Pull request successfully merged into master. Build succeeded: |
IsTopologicalTorsorIsTopologicalTorsor
…teristic * origin/master: (1051 commits) feat(RingTheory/Ideal): add Algebra.HasGoingUp (leanprover-community#40911) feat: add theorem that Bird's determinant algorithm computes Matrix.det (leanprover-community#41160) chore(scripts): update nolints.json (leanprover-community#41908) chore(AlgebraicTopology/Reedy): cosmetic cleanups (leanprover-community#41581) doc: fix typos in SimplicialSet docstrings (leanprover-community#41571) chore: update Mathlib dependencies 2026-07-18 (leanprover-community#41901) doc: fix composition order in Presieve.pullback docstring (leanprover-community#41573) chore: update Mathlib dependencies 2026-07-18 (leanprover-community#41894) doc: fix the docstring of `IsTopologicalTorsor` (leanprover-community#41780) feat(RingTheory/Localization/Integer): cardinality of `finsetIntegerMultiple` (leanprover-community#41688) chore(RingTheory/Polynomial/Basic): golf `degreeLTEquiv` (leanprover-community#39514) feat(Analysis/Convex/TotallyBounded): strengthen to an iff (leanprover-community#41226) chore(SpecialFunctions/Log): fix naming typo (leanprover-community#41773) chore(Data/Vector): add `grind` to cons lemmas (leanprover-community#39098) feat(Analysis/Normed): add additional symm lemmas (leanprover-community#41149) chore(MathlibTest): fix defLemma warnings (leanprover-community#40593) chore(Data/SetLike/Basic): generalise instance (leanprover-community#40025) feat(Analysis): use `IsApply` for `GroupSeminorm` (leanprover-community#41560) chore(Order/ConditionallyCompletePartialOrder/Indexed): use `to_dual` more to kill `TODO` (leanprover-community#41589) feat(Analysis/InnerProductSpace/TensorProduct): continuous version of `TensorProduct.mk` (leanprover-community#40340) ... # Conflicts: # Mathlib/Algebra/Group/Subgroup/Basic.lean
The docstring incorrectly refers to
+ᵥand-ᵥinstead of their multiplicative versions.