Skip to content

[Merged by Bors] - doc: fix the docstring of IsTopologicalTorsor#41780

Closed
gasparattila wants to merge 1 commit into
leanprover-community:masterfrom
gasparattila:IsTopologicalTorsor-doc-fix
Closed

[Merged by Bors] - doc: fix the docstring of IsTopologicalTorsor#41780
gasparattila wants to merge 1 commit into
leanprover-community:masterfrom
gasparattila:IsTopologicalTorsor-doc-fix

Conversation

@gasparattila

Copy link
Copy Markdown
Contributor

The docstring incorrectly refers to +ᵥ and -ᵥ instead of their multiplicative versions.


Open in Gitpod

The docstring incorrectly refers to `+ᵥ` and `-ᵥ` instead of their multiplicative versions.
@gasparattila

Copy link
Copy Markdown
Contributor Author

easy

@github-actions github-actions Bot added the easy < 20s of review time. See the lifecycle page for guidelines. label Jul 15, 2026
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown

PR summary f3035c0fdf

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit f3035c0).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit f3035c0fdf
Reference commit 11d11a11a6

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Jul 15, 2026
Comment on lines +31 to 32
/-- A topological torsor over a topological group is a torsor where `` and `/ₛ` are continuous. -/
@[to_additive]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gasparattila okay, but please also include the docstring for the additive versions in the to_additive bit, like so:

Suggested change
/-- A topological torsor over a topological group is a torsor where `•` and `/ₛ` are continuous. -/
@[to_additive]
/-- A topological torsor over a topological group is a torsor where `•` and `/ₛ` are continuous. -/
@[to_additive /-- A topological additive torsor over a topological additive group is a torsor
where `+ᵥ` and `-ᵥ` are continuous. -/]

I'll just add this for now and merge it, but I wanted to point out that we should have both.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j-loreaux IsTopologicalAddTorsor is defined above, it already has a docstring

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j-loreaux I've undone your change, since it would unnecessarily overwrite the existing docstring. I've also made #41883 to warn in this kind of situation.

@j-loreaux j-loreaux added the auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. label Jul 17, 2026
@gasparattila
gasparattila force-pushed the IsTopologicalTorsor-doc-fix branch from 6eefc0f to f3035c0 Compare July 18, 2026 08:53
@mathlib-auto-merge

Copy link
Copy Markdown

As this PR is labelled auto-merge-after-CI, we are now sending it to bors:

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Jul 18, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jul 18, 2026
The docstring incorrectly refers to `+ᵥ` and `-ᵥ` instead of their multiplicative versions.
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Jul 18, 2026
@mathlib-bors

mathlib-bors Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title doc: fix the docstring of IsTopologicalTorsor [Merged by Bors] - doc: fix the docstring of IsTopologicalTorsor Jul 18, 2026
@mathlib-bors mathlib-bors Bot closed this Jul 18, 2026
rosborn added a commit to rosborn/mathlib4 that referenced this pull request Jul 19, 2026
…teristic

* origin/master: (1051 commits)
  feat(RingTheory/Ideal): add Algebra.HasGoingUp (leanprover-community#40911)
  feat: add theorem that Bird's determinant algorithm computes Matrix.det (leanprover-community#41160)
  chore(scripts): update nolints.json (leanprover-community#41908)
  chore(AlgebraicTopology/Reedy): cosmetic cleanups (leanprover-community#41581)
  doc: fix typos in SimplicialSet docstrings (leanprover-community#41571)
  chore: update Mathlib dependencies 2026-07-18 (leanprover-community#41901)
  doc: fix composition order in Presieve.pullback docstring (leanprover-community#41573)
  chore: update Mathlib dependencies 2026-07-18 (leanprover-community#41894)
  doc: fix the docstring of `IsTopologicalTorsor` (leanprover-community#41780)
  feat(RingTheory/Localization/Integer): cardinality of `finsetIntegerMultiple` (leanprover-community#41688)
  chore(RingTheory/Polynomial/Basic): golf `degreeLTEquiv` (leanprover-community#39514)
  feat(Analysis/Convex/TotallyBounded): strengthen to an iff (leanprover-community#41226)
  chore(SpecialFunctions/Log): fix naming typo (leanprover-community#41773)
  chore(Data/Vector): add `grind` to cons lemmas (leanprover-community#39098)
  feat(Analysis/Normed): add additional symm lemmas (leanprover-community#41149)
  chore(MathlibTest): fix defLemma warnings (leanprover-community#40593)
  chore(Data/SetLike/Basic): generalise instance (leanprover-community#40025)
  feat(Analysis): use `IsApply` for `GroupSeminorm` (leanprover-community#41560)
  chore(Order/ConditionallyCompletePartialOrder/Indexed): use `to_dual` more to kill `TODO` (leanprover-community#41589)
  feat(Analysis/InnerProductSpace/TensorProduct): continuous version of `TensorProduct.mk` (leanprover-community#40340)
  ...

# Conflicts:
#	Mathlib/Algebra/Group/Subgroup/Basic.lean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. bors-staging This PR is currently being built by bors on the staging branch. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants