Skip to content

chore: eta reduce in proofs#41875

Draft
felixpernegger wants to merge 1 commit into
leanprover-community:masterfrom
felixpernegger:etareducation
Draft

chore: eta reduce in proofs#41875
felixpernegger wants to merge 1 commit into
leanprover-community:masterfrom
felixpernegger:etareducation

Conversation

@felixpernegger

Copy link
Copy Markdown
Contributor

Simplify proof by applying eta reduction (i.e. f instead of fun x => f x).

This is purely stylistic.


Open in Gitpod

@felixpernegger

Copy link
Copy Markdown
Contributor Author

!bench

@felixpernegger
felixpernegger marked this pull request as draft July 17, 2026 21:19
@mathlib-bors

mathlib-bors Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

This pull request is now in draft mode. No active bors state needed cleanup.

While this PR remains draft, bors will ignore commands on this PR. Mark it ready for review before using commands like bors r+ or bors try.

@leanprover-radar

leanprover-radar commented Jul 17, 2026

Copy link
Copy Markdown

Benchmark results for 86e6105 against 324e878 are in. No significant results found. @felixpernegger

  • 🟥 build//instructions: +146.5G (+0.10%)

Small changes (1🟥)

  • 1 hidden

@github-actions

Copy link
Copy Markdown

PR summary 86e6105079

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean -- pending)

Computed after the build finishes.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 86e6105079
Reference commit 324e878abc

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@felixpernegger

Copy link
Copy Markdown
Contributor Author

!bench

@leanprover-radar

Copy link
Copy Markdown

Benchmark results for 86e6105 against 324e878 are in. (These commits have already been benchmarked in a previous command.) No significant results found. @felixpernegger

  • 🟥 build//instructions: +146.5G (+0.10%)

Small changes (1🟥)

  • 1 hidden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants