Skip to content

feat(Algebra/Order/Floor/Ring): positivity for Int.fract#41877

Open
BoltonBailey wants to merge 2 commits into
leanprover-community:masterfrom
BoltonBailey:fract-positivity
Open

feat(Algebra/Order/Floor/Ring): positivity for Int.fract#41877
BoltonBailey wants to merge 2 commits into
leanprover-community:masterfrom
BoltonBailey:fract-positivity

Conversation

@BoltonBailey

@BoltonBailey BoltonBailey commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

This PR adds a positivity extension for Int.fract, which is always nonnegative.

I used Claude Code to prepare this PR.


Open in Gitpod

@BoltonBailey BoltonBailey added LLM-generated PRs with substantial input from LLMs - review accordingly t-meta Tactics, attributes or user commands labels Jul 18, 2026
@github-actions

github-actions Bot commented Jul 18, 2026

Copy link
Copy Markdown

PR summary 97a9457233

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 97a9457).

  • +1 new declarations
  • −0 removed declarations
+Mathlib.Meta.Positivity.evalIntFract

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 97a9457233
Reference commit 121d7591ea

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Jul 18, 2026
@BoltonBailey BoltonBailey changed the title feat(Positivity): add extension for Int.fract feat(Algebra/Order/Floor/Ring): add extension for Int.fract Jul 18, 2026
@BoltonBailey BoltonBailey changed the title feat(Algebra/Order/Floor/Ring): add extension for Int.fract feat(Algebra/Order/Floor/Ring): positivity for Int.fract Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LLM-generated PRs with substantial input from LLMs - review accordingly t-algebra Algebra (groups, rings, fields, etc) t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant