Skip to content

feat(Tactic): automatic positivity attribute#41895

Draft
BoltonBailey wants to merge 8 commits into
leanprover-community:masterfrom
BoltonBailey:autopositivity
Draft

feat(Tactic): automatic positivity attribute#41895
BoltonBailey wants to merge 8 commits into
leanprover-community:masterfrom
BoltonBailey:autopositivity

Conversation

@BoltonBailey

@BoltonBailey BoltonBailey commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

This PR makes an attribute that can be applied directly to lemmas to have them be used by positivity, without additional metaprogramming.


Open in Gitpod

@BoltonBailey BoltonBailey added WIP Work in progress LLM-generated PRs with substantial input from LLMs - review accordingly labels Jul 18, 2026
@github-actions

github-actions Bot commented Jul 18, 2026

Copy link
Copy Markdown

PR summary f96958cdab

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
../mathlib-ci/scripts/pr_summary/import_trans_difference.sh all
There are 3829 files with changed transitive imports taking up over 178439 characters: this is too many to display!
You can run this locally from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci


Declarations diff (regex)

+ AutoEntry
+ AutoRel
+ AutoRel.toStrictness
+ applyAutoLemma
+ double
+ double_pos
+ evalAutoPositivityLemmas
+ isZeroExpr
+ nat_sqrt_pos_of_pos
+ parseConcl?
- evalIte

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean -- pending)

Computed after the build finishes.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit f96958cdab
Reference commit f041774a2d

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LLM-generated PRs with substantial input from LLMs - review accordingly WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant