Add a new UI for all emails#28
Open
TamaroWalter wants to merge 2 commits into
Open
Conversation
The tests only tested if mails were send correctly. As this is rather a moodle core functionality and not a lsf_unification one, this kind of tests gives no insight if the plugin is bug-free. New tests should be written in the future
Member
|
Hi there, I already had a quick look: The HTML emails look fancy but I am not so sure whether we really want to send HTML emails. Ideally, the look and feel of the emails should then match the Moodle theme otherwise it would be hard to reuse this plugin on other instances (like examweb). I do like the new plain-text version, though. However, I want to have a more detailed look at the code refactorings, maybe this is something we can merge in any case (together with the new plain-text versions). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔀 Purpose of this PR:
📝 Description:
The emails were a mess, they were ugly and the creation used a lot of unreadable parameters (
$params->a, $params->e). I redesigned the ui and process of sending a mail:lsf_unificationdomain but in the moodle core. Our tests should cover our functions.📋 Checklist
Please confirm the following (check all that apply):
var_dump()orvar_exportor any other debugging statements (or commented out code) thatshould not appear on the productive branch.
🧾📸🌐 Additional Information (like screenshots, documentation, links, etc.)
How the email looked before:

How the mails look now: