Skip to content

Fix get_doubles(). #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
Mar 24, 2026
Merged

Fix get_doubles(). #735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions include/bitcoin/database/impl/query/consensus.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,14 +477,22 @@ bool CLASS::get_doubles(tx_links& out, const point& point) const NOEXCEPT
if (!store_.duplicate.exists(point))
return true;

auto success = false;
for (auto it = store_.tx.it(point.hash()); it != it.end(); ++it)
// Get the [tx.hash:index] of each spender of the point (index unused).
const auto spenders = get_spenders(point);
bool found{};

// Inpoints are deduped by the std::set.
for (const auto& spender: spenders)
{
success = true;
out.push_back(*it);
// Exhaustive enumeration of all txs with spender hash.
for (auto it = store_.tx.it(spender.hash()); it != it.end(); ++it)
{
found = true;
out.push_back(*it);
}
}

return success;
return found;
}

TEMPLATE
Expand Down
Loading