fix: accept interop peer records in identify and rendezvous#6384
Open
Azzurra88 wants to merge 1 commit intolibp2p:masterfrom
Open
fix: accept interop peer records in identify and rendezvous#6384Azzurra88 wants to merge 1 commit intolibp2p:masterfrom
Azzurra88 wants to merge 1 commit intolibp2p:masterfrom
Conversation
jxs
reviewed
Apr 16, 2026
Member
There was a problem hiding this comment.
Hi, and thanks for this, but why would someone want to use both payload types?
#6204 did not introduce any migration, it just offered a function compatible with go and js libp2p payload types, but one can keep using the previous one if only interacting with rust-libp2p.
Can you share your usecase?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Accept both legacy and standard interop peer record envelopes in the identify and rendezvous decode paths.
This keeps signed peer records usable during the migration introduced by
PeerRecord::*_interopwithout changing the default envelope encoder. It also adds focused tests for the core helper and both protocol consumers.Notes & open questions
This only relaxes decoding on the consumer side. Changelog entries for
libp2p-core,libp2p-identify, andlibp2p-rendezvousmay still be needed before opening a PR.Change checklist