Skip to content

Make formatting possible#815

Open
kastoestoramadus wants to merge 2 commits into
lightbend:mainfrom
kastoestoramadus:formatting-optins
Open

Make formatting possible#815
kastoestoramadus wants to merge 2 commits into
lightbend:mainfrom
kastoestoramadus:formatting-optins

Conversation

@kastoestoramadus

@kastoestoramadus kastoestoramadus commented Apr 22, 2025

Copy link
Copy Markdown

Allow the config library to be used as a formatter.

Rendering options added:

  • don't reorder entries,
  • control indentation,
  • default assign operator,

#693

Let me know if such improvement will be accept to merge. For now I've seen your lib is in maintenance mode.

@lightbend-cla-validator

Copy link
Copy Markdown
Collaborator

Hi @kastoestoramadus,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Akka Contributors License Agreement:

https://www.lightbend.com/contribute/cla

@kastoestoramadus kastoestoramadus marked this pull request as draft April 22, 2025 05:57
@kastoestoramadus kastoestoramadus marked this pull request as ready for review April 22, 2025 13:16
@ennru

ennru commented Sep 11, 2025

Copy link
Copy Markdown
Member

Hi @kastoestoramadus,
Thank you for suggesting this quite useful feature and it looks indeed less intrusive than I would have expected. Are you willing to take this to a full implementation?

@kastoestoramadus

Copy link
Copy Markdown
Author

I don't know. You've responded after 5 months :/ .
I've already implemented it in sconfig alternative repo with more features.

@ennru

ennru commented Sep 26, 2025

Copy link
Copy Markdown
Member

I understand your frustration. We've been a bit neglectful of this repository and are also cautious about making changes.
Thank you again for suggesting it.

@kastoestoramadus kastoestoramadus force-pushed the formatting-optins branch 2 times, most recently from 7c0fbe8 to a524015 Compare December 1, 2025 21:23
@ennru

ennru commented Dec 2, 2025

Copy link
Copy Markdown
Member
[error] Test com.typesafe.config.impl.ConfigDefaultRenderingTest.properArrayConcat failed: com.typesafe.config.ConfigException$WrongType: String: 1: Cannot concatenate object or list with a non-object-or-list, SimpleConfigList([1,2]) and Quoted(" ") are not compatible, took 0.012 sec

@kastoestoramadus

kastoestoramadus commented Dec 2, 2025

Copy link
Copy Markdown
Author

@ennru breaking commit added intentionally:

@ekrich

ekrich commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

@ennru We are trying to be careful we don't fundamentally change the way config works in ekrich/sconfig so it is compatible with this repo. We haven't ported a couple of Java centric features but may if requested. Also, we refer to the docs in this repository and we don't want to maintain them, plus they are the official spec. Feel free to back port the rendering features that we added or any bugs we may fix.

@ennru

ennru commented Dec 15, 2025

Copy link
Copy Markdown
Member

Thanks. As this requires full attention to the details to not cause any unexpected consequences, I'm afraid we at Akka do not have capacity to take this forward.

@ennru ennru force-pushed the formatting-optins branch from a524015 to 83b8fcf Compare April 24, 2026 06:55
@ennru

ennru commented Apr 24, 2026

Copy link
Copy Markdown
Member

I'm sorry this took so long...

The problem was solved with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants