-
Notifications
You must be signed in to change notification settings - Fork 73
LCORE-948: Restart prow e2e pod #1181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
radofuchs
merged 11 commits into
lightspeed-core:main
from
radofuchs:restart_prow_e2e_pod
Feb 25, 2026
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7acb585
update workflow to restart the pod
fa81915
fix black
123ba8c
restore original timeout
ae0d01e
fixes from review comments
8187346
formatting fix
6ac7d88
enable secrets in prow
a867ebf
add debug logs with timestamps
6d1e377
add longer timeout to port forward
076c41d
end test run without exceptions
67b55d1
enable env
b48223f
Merge branch 'lightspeed-core:main' into restart_prow_e2e_pod
radofuchs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
tests/e2e-prow/rhoai/configs/lightspeed-stack-auth-noop-token.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| name: Lightspeed Core Service (LCS) | ||
| service: | ||
| host: 0.0.0.0 | ||
| port: 8080 | ||
| auth_enabled: false | ||
| workers: 1 | ||
| color_log: true | ||
| access_log: true | ||
| llama_stack: | ||
| # Uses a remote llama-stack service | ||
| # The instance would have already been started with a llama-stack-run.yaml file | ||
| use_as_library_client: false | ||
| # Alternative for "as library use" | ||
| # use_as_library_client: true | ||
| # library_client_config_path: <path-to-llama-stack-run.yaml-file> | ||
| url: http://${env.E2E_LLAMA_HOSTNAME}:8321 | ||
| api_key: xyzzy | ||
| user_data_collection: | ||
| feedback_enabled: true | ||
| feedback_storage: "/tmp/data/feedback" | ||
| transcripts_enabled: true | ||
| transcripts_storage: "/tmp/data/transcripts" | ||
|
|
||
| # Conversation cache for storing Q&A history | ||
| conversation_cache: | ||
| type: "sqlite" | ||
| sqlite: | ||
| db_path: "/tmp/data/conversation-cache.db" | ||
|
|
||
| authentication: | ||
| module: "noop-with-token" |
25 changes: 25 additions & 0 deletions
25
tests/e2e-prow/rhoai/configs/lightspeed-stack-auth-rh-identity.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| name: Lightspeed Core Service (LCS) - RH Identity Auth | ||
| service: | ||
| host: 0.0.0.0 | ||
| port: 8080 | ||
| auth_enabled: true | ||
| workers: 1 | ||
| color_log: true | ||
| access_log: true | ||
| llama_stack: | ||
| use_as_library_client: false | ||
| url: http://${env.E2E_LLAMA_HOSTNAME}:8321 | ||
| api_key: xyzzy | ||
| user_data_collection: | ||
| feedback_enabled: true | ||
| feedback_storage: "/tmp/data/feedback" | ||
| transcripts_enabled: true | ||
| transcripts_storage: "/tmp/data/transcripts" | ||
| conversation_cache: | ||
| type: "sqlite" | ||
| sqlite: | ||
| db_path: "/tmp/data/conversation-cache.db" | ||
| authentication: | ||
| module: "rh-identity" | ||
| rh_identity_config: | ||
| required_entitlements: ["rhel"] |
25 changes: 25 additions & 0 deletions
25
tests/e2e-prow/rhoai/configs/lightspeed-stack-invalid-feedback-storage.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| name: Lightspeed Core Service (LCS) | ||
| service: | ||
| host: 0.0.0.0 | ||
| port: 8080 | ||
| auth_enabled: false | ||
| workers: 1 | ||
| color_log: true | ||
| access_log: true | ||
| llama_stack: | ||
| # Uses a remote llama-stack service | ||
| # The instance would have already been started with a llama-stack-run.yaml file | ||
| use_as_library_client: false | ||
| # Alternative for "as library use" | ||
| # use_as_library_client: true | ||
| # library_client_config_path: <path-to-llama-stack-run.yaml-file> | ||
| url: http://${env.E2E_LLAMA_HOSTNAME}:8321 | ||
| api_key: xyzzy | ||
| user_data_collection: | ||
| feedback_enabled: true | ||
| feedback_storage: "/invalid" | ||
| transcripts_enabled: true | ||
| transcripts_storage: "/tmp/data/transcripts" | ||
|
|
||
| authentication: | ||
| module: "noop-with-token" | ||
27 changes: 27 additions & 0 deletions
27
tests/e2e-prow/rhoai/configs/lightspeed-stack-no-cache.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| name: Lightspeed Core Service (LCS) | ||
| service: | ||
| host: 0.0.0.0 | ||
| port: 8080 | ||
| auth_enabled: false | ||
| workers: 1 | ||
| color_log: true | ||
| access_log: true | ||
| llama_stack: | ||
| # Uses a remote llama-stack service | ||
| # The instance would have already been started with a llama-stack-run.yaml file | ||
| use_as_library_client: false | ||
| # Alternative for "as library use" | ||
| # use_as_library_client: true | ||
| # library_client_config_path: <path-to-llama-stack-run.yaml-file> | ||
| url: http://${env.E2E_LLAMA_HOSTNAME}:8321 | ||
| api_key: xyzzy | ||
| user_data_collection: | ||
| feedback_enabled: true | ||
| feedback_storage: "/tmp/data/feedback" | ||
| transcripts_enabled: true | ||
| transcripts_storage: "/tmp/data/transcripts" | ||
|
|
||
| # NO conversation_cache configured - for testing error handling | ||
|
|
||
| authentication: | ||
| module: "noop-with-token" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| name: Lightspeed Core Service (RBAC E2E Tests) | ||
| service: | ||
| host: 0.0.0.0 | ||
| port: 8080 | ||
| auth_enabled: true | ||
| workers: 1 | ||
| color_log: true | ||
| access_log: true | ||
|
|
||
| llama_stack: | ||
| use_as_library_client: false | ||
| url: http://${env.E2E_LLAMA_HOSTNAME}:8321 | ||
| api_key: xyzzy | ||
|
|
||
| user_data_collection: | ||
| feedback_enabled: true | ||
| feedback_storage: "/tmp/data/feedback" | ||
| transcripts_enabled: true | ||
| transcripts_storage: "/tmp/data/transcripts" | ||
|
|
||
| # Conversation cache for storing Q&A history | ||
| conversation_cache: | ||
| type: "sqlite" | ||
| sqlite: | ||
| db_path: "/tmp/data/conversation-cache.db" | ||
|
|
||
| # JWK token authentication with role extraction | ||
| authentication: | ||
| module: "jwk-token" | ||
| jwk_config: | ||
| url: "http://mock-jwks:8000/.well-known/jwks.json" | ||
| jwt_configuration: | ||
| user_id_claim: "sub" | ||
| username_claim: "name" | ||
| # Role rules: extract roles from JWT claims | ||
| role_rules: | ||
| # Grant 'admin' role to users with admin=true in JWT | ||
| - jsonpath: "$.admin" | ||
| operator: "equals" | ||
| value: [true] | ||
| roles: ["admin"] | ||
| # Grant 'user' role to users with role=user in JWT | ||
| - jsonpath: "$.role" | ||
| operator: "equals" | ||
| value: ["user"] | ||
| roles: ["user"] | ||
| # Grant 'viewer' role to users with role=viewer in JWT | ||
| - jsonpath: "$.role" | ||
| operator: "equals" | ||
| value: ["viewer"] | ||
| roles: ["viewer"] | ||
| # Grant 'query_only' role based on permissions array containing 'query' | ||
| - jsonpath: "$.permissions[*]" | ||
| operator: "contains" | ||
| value: "query" | ||
| roles: ["query_only"] | ||
|
|
||
| # Authorization: map roles to actions | ||
| authorization: | ||
| access_rules: | ||
| # Admin role gets full access | ||
| - role: "admin" | ||
| actions: ["admin"] | ||
| # User role can query, access conversations, and provide feedback | ||
| - role: "user" | ||
| actions: | ||
| - "query" | ||
| - "streaming_query" | ||
| - "get_conversation" | ||
| - "list_conversations" | ||
| - "delete_conversation" | ||
| - "update_conversation" | ||
| - "feedback" | ||
| - "get_models" | ||
| - "get_tools" | ||
| - "info" | ||
| - "model_override" | ||
| # Viewer role can only read (no mutations) | ||
| - role: "viewer" | ||
| actions: | ||
| - "get_conversation" | ||
| - "list_conversations" | ||
| - "get_models" | ||
| - "get_tools" | ||
| - "info" | ||
| # Query-only role can only query (no model_override - must use defaults) | ||
| - role: "query_only" | ||
| actions: | ||
| - "query" | ||
| - "streaming_query" | ||
| # Everyone (*) role gets basic info access | ||
| - role: "*" | ||
| actions: | ||
| - "info" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auth_enabled: falselikely makes theauthenticationblock a no-op — clarify intent.When auth is disabled, the configured
noop-with-tokenmodule is never invoked. If this config is only meant to exercise the invalid-storage-path error path and does not require token-based requests, theauthenticationblock is dead config and can be removed. If token parsing is still needed (e.g., for user-tracking), the intent should be documented with a comment.Also applies to: 24-25
🤖 Prompt for AI Agents