Avoid boot loop when there are dnf network issues

[afbjorklund]

Only try to reboot when upgradePackages is true, and check the network connectivity before checking if a restart is needed.

Also don't hide the stderr output, in case of any errors, and also show the list of packages that are requiring the reboot.

Closes #4440

first boot:

+ command -v dnf
+ dnf -h needs-restarting
+ dnf check-update
Updating and loading repositories:
Repositories loaded.
+ '[' 0 '!=' 1 ']'
+ dnf needs-restarting -r
Updating and loading repositories:
 Fedora 43 openh264 (From Cisco) - x86_ 100% |   1.6 KiB/s |  10.1 KiB |  00m06s
 Fedora 43 - x86_64 - Updates           100% |   1.7 MiB/s |  21.9 MiB |  00m13s
 Fedora 43 - x86_64                     100% |   2.2 MiB/s |  57.8 MiB |  00m26s
Repositories loaded.
Core libraries or services have been updated since boot-up:
  * glib2
  * gnutls
  * kernel-core
  * kernel-modules-core
  * libxcrypt
  * openssl-libs
  * systemd

Reboot is required to fully utilize these updates.
More information: https://access.redhat.com/solutions/27943
+ systemctl reboot

Broadcast message from root@localhost (Mon 2025-12-08 12:46:02 CET):

The system will reboot now!

second boot:

+ command -v dnf
+ dnf -h needs-restarting
+ dnf check-update
Updating and loading repositories:
Repositories loaded.
+ '[' 0 '!=' 1 ']'
+ dnf needs-restarting -r
Updating and loading repositories:
Repositories loaded.
No core libraries or services have been updated since boot-up.
Reboot should not be necessary.

[jandubois]

I don't understand which part of the PR is supposed to stop the reboot loop in case there is a network problem.

[jandubois]

It bothers me that we do these silly translations from booleans to environment variables that have to be set to 1 or the empty string. Or in this case 0.

Why don't we assign the boolean value directly and deal with it that the variable will be set to true or false?

Suggested change

	{{- if .UpgradePackages}}
	LIMA_CIDATA_UPGRADE_PACKAGES=1
	{{- else}}
	LIMA_CIDATA_UPGRADE_PACKAGES=0
	{{- end}}
	LIMA_CIDATA_UPGRADE_PACKAGES={{.UpgradePackages}}

[afbjorklund]

I was just following the rest of them, either way

[afbjorklund]

But then it would be more on the lines of:

$LIMA_CIDATA_UPGRADE_PACKAGES || exit 0

[afbjorklund]

And using 0 is a bit unconventional, not "ifdef"

[afbjorklund]

Apparently that was my bad, it was only 1 being used