[NPU]:Add support for the grpo_loss operator.#1142
Closed
TianHao324 wants to merge 1 commit intolinkedin:mainfrom
Closed
[NPU]:Add support for the grpo_loss operator.#1142TianHao324 wants to merge 1 commit intolinkedin:mainfrom
TianHao324 wants to merge 1 commit intolinkedin:mainfrom
Conversation
Contributor
Author
|
@Tcc0403 would you mind having a preview? |
Contributor
|
@TianHao324 Does this duplicate the functionality of #1121? |
Contributor
Author
Sorry, I didn't see this PR. I will close mine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
To address the ub overflow issue in the benchmark, we have added an operator with a NPU-friendly implementation of grpo_loss.
Testing Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence