TPT-4446: Fix failing smoke tests#974
Open
mawilk90 wants to merge 6 commits into
Open
Conversation
mawilk90
added
improvement
mawilk90
requested review from
psnoch-akamai and
yec-akamai
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates integration smoke tests and recorded fixtures to address recent failures, primarily around resource naming collisions, asynchronous readiness, and updated platform capabilities/engines.
Changes:
- Make created resources (volumes/domains) less collision-prone and wait for volume readiness before deletion.
- Update Postgres managed database engine version used in tests.
- Adjust LKE enterprise BYO-VPC smoke test to use dynamic region selection and request IPv6 VPC ranges; refresh multiple fixtures accordingly.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/integration/volumes_test.go | Randomizes volume label and waits for active status before deletion to reduce flakes. |
| test/integration/postgres_test.go | Updates the Postgres engine version used when creating test DB clusters. |
| test/integration/lke_clusters_test.go | Switches region selection to capabilities-based lookup and adds IPv6 range options for VPC creation. |
| test/integration/fixtures/TestVolume_List.yaml | Updates recorded region/volume interactions and response shapes (new fields/capabilities). |
| test/integration/fixtures/TestVolume_Create.yaml | Updates recorded volume-create flow (including additional GET/fields). |
| test/integration/fixtures/TestAccountEvents_List.yaml | Refreshes recorded interactions for account events test. |
| test/integration/domains_test.go | Randomizes domain name to avoid collisions. |
| test/integration/account_events_test.go | Adds a delay to reduce flakiness when querying for newly-created config events. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…base, TestVolume_Create_smoke # Conflicts: # test/integration/lke_clusters_test.go # test/integration/volumes_test.go
…prise_BYOVPC_smoke
mawilk90
force-pushed
the
hotfix/flaky_smoke_tests_fixes
branch
from
07679fe to
c2506d6
Compare
mawilk90
removed
the
do-not-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Nightly smoke tests fail and some fixes/improvements are required.
Tags needed for
TestLKECluster_Enterprise_BYOVPC_smoke:lke-beta-ff-vpcvpc-ipv6vpc-ipv6-enterprisevpc-ipv6-extra-speciallke-beta-ff-vpc-ipv4-only<-- If you have it, please remove itNote:
TestMonitorDashboards_Get_smoke: as discussed on Slack, ACLP Team confirmed that the API changes have been made (that's why the test fails) and they're going to udpate SDKs soon (group_bywill be returned at both the dashboard level and the widget level) - the test is skipped for now.✔️ How to Test
make test-smoke