upcoming: [UIE-9395] - Edit Connection Pool Drawer #13304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hana-akamai
force-pushed
the
UIE-9395-edit-connection-pool
branch
from
e0b0c7f to
c9100de
Compare
hana-akamai
commented
Jan 22, 2026
hana-akamai
requested review from
aaleksee-akamai,
mpolotsk-akamai and
smans-akamai
...rc/features/Databases/DatabaseDetail/DatabaseNetworking/DatabaseEditConnectionPoolDrawer.tsx
Show resolved
Hide resolved
...rc/features/Databases/DatabaseDetail/DatabaseNetworking/DatabaseEditConnectionPoolDrawer.tsx
Show resolved
Hide resolved
...rc/features/Databases/DatabaseDetail/DatabaseNetworking/DatabaseEditConnectionPoolDrawer.tsx
Show resolved
Hide resolved
Contributor
|
Looks like there's a merge conflict after the recent merge. |
smans-akamai
approved these changes
Jan 23, 2026
Contributor
smans-akamai
left a comment
smans-akamai
left a comment
There was a problem hiding this comment.
All my feedback was addressed and I've tested out the changes! This looks good to me, so I've approved!
aaleksee-akamai
approved these changes
Jan 26, 2026
Contributor
aaleksee-akamai
left a comment
aaleksee-akamai
left a comment
There was a problem hiding this comment.
Looks good but I see that there're some failed tests in DatabaseEditConnectionPoolDrawer.test.tsx
mpolotsk-akamai
approved these changes
Jan 26, 2026
Contributor
mpolotsk-akamai
left a comment
mpolotsk-akamai
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
smans-akamai
requested changes
Jan 26, 2026
Contributor
There was a problem hiding this comment.
As @aaleksee-akamai mentioned, it looks like there are some failing tests for this. Are you able to reproduce these locally @hana-akamai?
These should probably be fixed before we merge this in.
github-project-automation
bot
moved this from Approved
to Changes Requested
in Cloud Manager
smans-akamai
approved these changes
Jan 26, 2026
Contributor
smans-akamai
left a comment
smans-akamai
left a comment
There was a problem hiding this comment.
Tests look good so I'm reapproving! Thanks pushing up the fix!
github-project-automation
bot
moved this from Changes Requested
to Approved
in Cloud Manager
Collaborator
Cloud Manager UI test results🔺 2 failing tests on test run #7 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts,cypress/e2e/core/linodes/create-linode-with-add-ons.spec.ts" |
||||||||||||||||||||
dchyrva-akamai
pushed a commit
to dchyrva-akamai/manager
that referenced
this pull request
Jan 27, 2026
## Description 📝 Add Edit Connection Pool drawer to the Database Networking -> PgBouncer Connection Pools section ## How to test 🧪 ### Prerequisites (How to setup test environment) - Ensure you have the Database PgBouncer flag on and the legacy MSW on ### Verification steps (How to verify changes) - [ ] Go to a postgresql Database cluster's networking tab and scroll to the PgBouncer Connection Pools section - [ ] Edit an existing connection pool in the table via action menu dropdown - [ ] The edit drawer should have the connection pool's details prefilled with the label disabled - [ ] Make edits, click save, and check the network request - [ ] Test error states, edits should not be saved if the user clicks cancel or closes out of the drawer without saving ``` pnpm test DatabaseEditConnectionPoolDrawer ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Add Edit Connection Pool drawer to the Database Networking -> PgBouncer Connection Pools section
Scope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
Screen.Recording.2026-01-22.at.1.10.38.PM.mov
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅