fix(cable): GetInfo timing out before BLE handshake completes#226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hybrid currently fails immediately with
Transport(Timeout)(issue #225) because the protocol layer wraps each CTAP2 exchange in a 250ms wall-clock timeout, but the cable transport legitimately blocks for the BLE handshake before that timeout window even applies.Removing the outer wrap is safe. HID already enforces its wall-clock deadline inside its own receive path (the original motivation for the wrap), and the per-leg send and receive timeouts on every transport are unchanged. The change restores the pre-regression shape of the protocol layer and adds a unit test that pins the behaviour by sleeping the mock channel's send past the GetInfo timeout and asserting the call still reaches the response.
Fixes #225