Run tests without depending on the host at all#441
Merged
bilelmoussaoui merged 12 commits intomainfrom Mar 29, 2026
Merged
Conversation
📊 Code Coverage Report
🎉 Great: Coverage increased by more than 1%! Coverage report generated by cargo-tarpaulin |
Collaborator
Author
|
The clippy warning failure is because the exported library types are not used by anything, we can silence them but that means any unused types when doing a binary build wouldn't be detected. I guess we can have a cargo clippy for the binary only and not run it for the library build... |
bilelmoussaoui
force-pushed
the
bilelmoussaoui/helpers-tests
branch
2 times, most recently
from
ceb1181 to
d080354
Compare
Handles the plain/encrypted part internally simplifying some of the tests a bit.
By adding helper methods that would use the passed tmpdir for tests ensuring isolated test runs without having to run the tests serially.
By using an internal override that simplifies everything, remove few unsafe usages, drop serial_test and make test less racy.
Avoids any dependency on the host and making sure we never affect the user keyrings.
as it timeouts out often on coverage tests
Except for python bindings, till we replace that with oo7-daemon eventually.
bilelmoussaoui
force-pushed
the
bilelmoussaoui/helpers-tests
branch
from
d080354 to
f7e3899
Compare
bilelmoussaoui
force-pushed
the
bilelmoussaoui/helpers-tests
branch
from
f7e3899 to
dbb40ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add various helper methods to no longer go through XDG_DATA_HOME or connect to the session bus. The client tests are now using a oo7-server lib crate that should never be published, but only used for tests. By doing so, we can run all the dbus client tests, particularly the ones requiring prompting.
This makes the tests run much faster as they no longer need to be run serially.