feat: add power-limit command#3077
Merged
igaw merged 2 commits intolinux-nvme:masterfrom Feb 10, 2026
Merged
Conversation
ikegami-t
force-pushed
the
feat-power-limit
branch
from
5b5d5fe to
fab4bbc
Compare
igaw
reviewed
Feb 9, 2026
nvme-print.c
Outdated
| { | ||
| switch (pls) { | ||
| case NVME_PSD_PS_NOT_REPORTED: | ||
| return "Reserved"; |
Contributor
Author
There was a problem hiding this comment.
No actually the values 00b and 11b are described as reserved by the NVMe base specification revision 2.3 as below so seems the definition name should be also NVME_PSD_PS_RESERVED changed or deleted.
Contributor
Author
There was a problem hiding this comment.
Just reconfirmed as the definitiopn added by the commit: e830543 and still the power state descriptor data structure (active) power scale desribed as below so fixed as mentioned. (Also for the power limit exactly the definitions should be separated.)
ikegami-t
force-pushed
the
feat-power-limit
branch
from
fab4bbc to
0b18552
Compare
Add feat_get() uidx parameter also for the command. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
This is for Power Threshold feature to get and set. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
ikegami-t
force-pushed
the
feat-power-limit
branch
from
0b18552 to
547c2ab
Compare
Contributor
Author
|
Just fixed as mentioned. |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add feat_get() uidx parameter also for the command.