feat: Add power measurement feature support.#3132
Conversation
Added "power-meas" feature. Fixed bug in power threshold printing code. Signed-off-by: Jim Munn <jlmunn@micron.com>
| nvme_show_result("Set %s: 0x%04x (%s)", power_meas_feat, cdw11, | ||
| sv ? "Save" : "Not save"); | ||
| nvme_feature_show_fields(fid, cdw11, NULL); | ||
| } |
There was a problem hiding this comment.
we recenetly changed how print error. instead of this snippet, it's possible to use something like this:
err = nvme_identify_ctrl(hdl, ctrl);
if (err) {
nvme_show_err("identify controller", err);
return err;
}
nvme_show_id_ctrl(ctrl, flags, vs);looks like feat-nvme.c needs this update too...
There was a problem hiding this comment.
Let's do this change in a different patch though.
@ikegami-t do want to update feat-nvme.c accordingly? Just asking because you have been working most of the time on this file.
There was a problem hiding this comment.
Sure will do it later. Thank you.
|
Thanks! |
|
Thanks for the fix. Just FYI: looks it was better to be done the threshold fix by a separated patch since not related to the power measurement feature support itself. |
|
@ikegami-t , I was debating with myself rather I should split this up and have the bug fix separately. I will do that next time. |
|
Thank you. Noted. |
3 participants
Added "power-meas" feature.
Fixed bug in power threshold printing code.