Skip to content

chore: update changelog to 2.0.37#763

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
mhduiy:dev-changelog-2.0.37
May 20, 2026
Merged

chore: update changelog to 2.0.37#763
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
mhduiy:dev-changelog-2.0.37

Conversation

@mhduiy
Copy link
Copy Markdown
Contributor

@mhduiy mhduiy commented May 20, 2026

更新说明

自动更新 changelog 到版本 2.0.37

变更内容

  • 更新 debian/changelog

版本信息

  • 新版本: 2.0.37
  • 目标分支: master

Summary by Sourcery

Chores:

  • Bump recorded package version to 2.0.37 in debian changelog.

update changelog to 2.0.37

Log: update changelog to 2.0.37
@github-actions
Copy link
Copy Markdown

TAG Bot

TAG: 2.0.37
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 20, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Debian packaging changelog to reflect release version 2.0.37 targeting master, with no code or configuration changes beyond the changelog entry itself.

File-Level Changes

Change Details Files
Update Debian changelog metadata for release 2.0.37.
  • Add or adjust the top changelog entry to set the new package version 2.0.37.
  • Ensure the changelog targets the master distribution/branch as indicated.
  • Preserve existing historical changelog entries without modification.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

你好!我是CodeGeeX。我已仔细审查了你提供的 Git Diff 内容。

本次提交是一个 Debian changelog 的更新,版本号从 2.0.36 升级到了 2.0.37,主要包含两个变更:

  1. feat: 增加 Wayland XDG activation token 支持,用于应用启动。
  2. fix: 禁用右键上下文菜单。

由于本次 Diff 仅涉及 debian/changelog 文件(属于打包和发布说明文档),不涉及实际的 C++/QML 等业务代码,因此我无法直接对语法逻辑、代码性能和代码安全进行评估。

不过,针对这份 Changelog 本身的规范性和质量,以及结合这两个变更点在实际代码实现中可能潜藏的风险,我提供以下审查意见和改进建议:

一、 Changelog 文本质量审查

  1. 日期格式问题(潜在风险)

    • 当前代码Wed, 20 May 2026 15:16:51 +0800
    • 审查意见:年份写的是 2026 年,这大概率是系统时间设置错误或手动编写时的笔误。虽然 dch 等工具可能会自动生成时间,但若未来某天构建系统对时间戳有校验,可能会导致打包失败。
    • 改进建议:确认当前实际日期,修正为正确的年份(如 20242025)。
  2. 版本号与分支规范

    • 审查意见:版本号 2.0.37 后面跟的是 unstable。如果这是准备发版的正式提交,通常需要根据 Debian 的发行版代号(如 unstable, stable, 或具体的代号如 noble, bookworm)来确认。如果只是日常开发合并,unstable 是合理的。

二、 关联代码逻辑与安全审查建议(基于变更描述)

虽然这里没有业务代码,但基于这两个功能点,我为你提供后续代码审查时应重点关注的方向:

1. 关于 feat: add Wayland XDG activation token support

XDG Activation 协议是 Wayland 下确保应用启动时能正确获取焦点(防止后台恶意弹窗窃取焦点)的重要机制。

  • 逻辑审查
    • 请确认 Token 是否在启动进程的整个生命周期中被正确传递(如通过 XDG_ACTIVATION_TOKEN 环境变量传递给子进程)。
    • 如果启动的是 D-Bus 服务,请确认是否通过 D-Bus 的 activation-token 字段正确传递。
  • 安全审查(重点)
    • Token 泄露风险:XDG Activation Token 是一次性的。如果在代码中被记录到日志中,不仅会导致 Token 失效,还可能引发安全问题。请确保日志系统中不会打印该 Token。
    • Token 校验:如果 dde-launchpad 自身也接收 Token,请确保对接收到的 Token 进行了合法性校验,防止伪造 Token 的焦点劫持攻击。

2. 关于 fix: disable context menu on right click

禁用右键菜单通常是为了解决某些交互冲突或 UI 状态异常。

  • 逻辑审查
    • 请确认禁用右键的范围是全局还是特定控件?如果全局禁用,是否会影响用户正常使用(如文本框内的右键复制粘贴)?
    • 如果是通过 event->ignore() 或过滤事件实现的,请确保事件过滤器的逻辑不会导致内存泄漏或事件循环阻塞。
  • 性能审查
    • 如果是通过重写 mousePressEvent 或安装事件过滤器来拦截右键事件,请确保拦截逻辑轻量,不要在鼠标事件的高频回调中执行耗时操作。
  • 代码质量
    • 建议在业务代码中增加明确的注释,说明为什么要禁用右键菜单(例如:// 禁用右键菜单以避免在 Wayland 下引起焦点冲突 Issue #xxx),避免后续维护者误删此逻辑。

总结

当前的 Changelog 修改本身没有严重问题,请务必修正日期年份。同时,建议你将实现上述两个 Feature/Fix 的 C++/QML 代码也一并提交审查,以便我能帮你深入排查逻辑、性能和安全性上的潜在隐患。

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, xionglinlin

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xionglinlin
Copy link
Copy Markdown
Contributor

/forcemerge

@deepin-bot
Copy link
Copy Markdown

deepin-bot Bot commented May 20, 2026

This pr force merged! (status: blocked)

@deepin-bot deepin-bot Bot merged commit e5e72a1 into linuxdeepin:master May 20, 2026
10 of 12 checks passed
@deepin-bot
Copy link
Copy Markdown

deepin-bot Bot commented May 20, 2026

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 2.0.37
  • Tag SHA: 0bca9e998a2d68cb832df38c7eba7d400f964e88
  • Commit SHA: e8dd8de2234eda518e77b06d37f96b0aa6c8f500
  • Tag Message:
    Release dde-launchpad 2.0.37
    
    
  • Tagger:
    • Name: mhduiy
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants