Skip to content

chore: Update version to 6.0.65#667

Merged
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:master
May 20, 2026
Merged

chore: Update version to 6.0.65#667
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:master

Conversation

@add-uos
Copy link
Copy Markdown
Contributor

@add-uos add-uos commented May 20, 2026

  • update version to 6.0.65

log: update version to 6.0.65

Summary by Sourcery

Chores:

  • Update Debian packaging changelog entry for version 6.0.65.

- update version to 6.0.65

log: update version to 6.0.65
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 20, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the project’s packaged version to 6.0.65 by adjusting the Debian changelog metadata to reflect the new release version and associated log entry.

File-Level Changes

Change Details Files
Bump package version metadata to 6.0.65 in the Debian changelog.
  • Update the version number entry in the changelog to 6.0.65.
  • Adjust the associated log/message text in the changelog to reference version 6.0.65.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link
Copy Markdown

TAG Bot

TAG: 6.0.65
EXISTED: no
DISTRIBUTION: unstable

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

你好!我是CodeGeeX。我已仔细审查了你提供的Git Diff内容。

本次提交主要包含两部分:一是Debian包的版本更新日志,二是修复了CPU缓存大小计算的问题。

以下是我的详细审查意见:

1. 语法与逻辑

  • Changelog格式debian/changelog 的格式基本符合Debian标准规范。包名、版本号、发行版、优先级、描述、作者和时间戳等元素齐全。
  • 版本号递增逻辑:从 6.0.64 升级到 6.0.65,符合修订版本的递增逻辑,没有问题。
  • ⚠️ 关键缺失:修复代码未包含在Diff中:本次Changelog明确指出了核心变更为 fix(cpu): fix CPU cache size calculation with shared list(修复带有共享列表的CPU缓存大小计算问题),但Diff中并没有包含任何C++或相关业务代码的修改。这通常意味着:
    • 提交时遗漏了文件(未执行 git add)。
    • 或者这是分步提交,仅提交了Changelog。
    • 建议:如果是完整的功能修复提交,请务必确保将修改的源代码文件(如涉及CPU信息读取的 .cpp/.h 文件)一同提交,否则这个版本发布后将不包含实际的修复逻辑。

2. 代码质量

  • 提交信息规范:Changelog中的描述 fix(cpu): fix CPU cache size calculation with shared list 采用了类似Conventional Commits的规范,清晰明了,能够让人快速了解修改的范围和内容,质量很高。
  • 大小写一致性:在上一条记录中使用了 Chore(首字母大写),而本次使用了小写的 chore。虽然不影响功能,但建议在同一个项目的Changelog中保持提交前缀的大小写风格统一。

3. 代码性能

  • 由于本次Diff未展示具体的业务代码,我仅针对Changelog中提到的**“shared list”**提供一些CPU缓存计算相关的通用性能建议:
    • 在处理CPU共享缓存(如L2/L3 Cache被多个逻辑核心共享)时,如果使用链表(std::list)来存储和遍历共享核心,时间复杂度为O(N),在核心数较多的服务器端设备上可能会有性能损耗。
    • 建议:如果业务代码中确实涉及对共享核心的频繁查找,建议在实现时使用基于哈希的集合(如 std::unordered_set)代替链表或数组,将查找复杂度降至O(1);同时注意在累加Cache Size时避免对同一个共享Cache重复计算。

4. 代码安全

  • 时间戳安全与合规:Changelog中的日期为 Wed, 20 May 2026 13:07:35 +0800,该日期处于未来时间(2026年)。虽然这不会引发安全漏洞,但在Debian打包规范中,时间戳应当反映实际构建或提交的时间。使用未来时间可能导致:
    • 在某些严格的CI/CD流水线中,由于时间校验不通过导致打包失败。
    • 与其他包的依赖时序产生冲突。
    • 建议:确认该时间戳是否为系统时间设置错误导致,建议使用真实的当前时间生成Changelog。通常该时间应由 dch 工具自动生成,请检查开发环境的系统时间是否准确。

总结
请重点检查是否遗漏了业务代码的提交。如果业务代码在其他Diff中,欢迎你将其提供给我,我将为你进行更深入的代码逻辑、性能和安全性审查。对于Changelog本身,请注意修正未来时间戳问题,并保持提交风格的一致性。

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind lzwind merged commit f368132 into linuxdeepin:master May 20, 2026
20 checks passed
@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented May 20, 2026

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.0.65
  • Tag SHA: e9d1b4d97eb12f5a195a1611f65a78bb2d123cf2
  • Commit SHA: 18aff6aa6ebe63acce801bd8a4de405bb432f503
  • Tag Message:
    Release deepin-devicemanager 6.0.65
    
    
  • Tagger:
    • Name: add-uos
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants