Skip to content

fix(scanner): remove redundant non-const resourceMap overload#898

Merged
zccrs merged 1 commit into
linuxdeepin:masterfrom
zzxyb:fix
May 27, 2026
Merged

fix(scanner): remove redundant non-const resourceMap overload#898
zccrs merged 1 commit into
linuxdeepin:masterfrom
zzxyb:fix

Conversation

@zzxyb
Copy link
Copy Markdown
Collaborator

@zzxyb zzxyb commented May 27, 2026

  1. Remove the non-const overload of resourceMap() in generated code
  2. Keep only the const version which is sufficient for all use cases
  3. Avoid unnecessary mutable access to internal resource map

Log: Removed non-const resourceMap() to prevent unintended modification of internal resource tracking

Influence:

  1. Verify all existing callers of resourceMap() still compile correctly
  2. Check that no code relies on the mutable version for resource managemen

Summary by Sourcery

Enhancements:

  • Simplify generated Wayland interface API by dropping the non-const resourceMap() overload and returning a const reference instead.

1. Remove the non-const overload of resourceMap() in generated code
2. Keep only the const version which is sufficient for all use cases
3. Avoid unnecessary mutable access to internal resource map

Log: Removed non-const resourceMap() to prevent unintended modification of internal resource tracking

Influence:
1. Verify all existing callers of resourceMap() still compile correctly
2. Check that no code relies on the mutable version for resource managemen
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 27, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the Qt Wayland scanner’s generated code to expose only a const reference accessor for the internal resource map, removing the non-const value-returning overload to prevent unintended mutation and unnecessary copying.

File-Level Changes

Change Details Files
Make resourceMap() accessor const-only and return a const reference to the internal resource map instead of providing a mutable, value-returning overload.
  • Removed the non-const resourceMap() overload that returned the resource map by value, allowing mutation and causing copies.
  • Updated the remaining resourceMap() overload to return a const QMultiMap reference instead of a const QMultiMap by value, avoiding unnecessary copies and enforcing immutability for callers.
src/modules/tools/qtwaylandscanner.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@zzxyb zzxyb requested a review from zccrs May 27, 2026 05:34
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Previously the const overload returned the QMultiMap by value, so changing it to a const reference is an observable API change for generated code (e.g., callers storing the map past the object's lifetime); if avoiding mutation is the goal, consider keeping the return-by-value const overload to preserve semantics while still dropping the non-const version.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Previously the const overload returned the QMultiMap by value, so changing it to a const reference is an observable API change for generated code (e.g., callers storing the map past the object's lifetime); if avoiding mutation is the goal, consider keeping the return-by-value const overload to preserve semantics while still dropping the non-const version.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zccrs, zzxyb

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zccrs zccrs merged commit a0e698f into linuxdeepin:master May 27, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants