fix(scanner): remove redundant non-const resourceMap overload#898
Merged
Conversation
1. Remove the non-const overload of resourceMap() in generated code 2. Keep only the const version which is sufficient for all use cases 3. Avoid unnecessary mutable access to internal resource map Log: Removed non-const resourceMap() to prevent unintended modification of internal resource tracking Influence: 1. Verify all existing callers of resourceMap() still compile correctly 2. Check that no code relies on the mutable version for resource managemen
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the Qt Wayland scanner’s generated code to expose only a const reference accessor for the internal resource map, removing the non-const value-returning overload to prevent unintended mutation and unnecessary copying. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Previously the const overload returned the QMultiMap by value, so changing it to a const reference is an observable API change for generated code (e.g., callers storing the map past the object's lifetime); if avoiding mutation is the goal, consider keeping the return-by-value const overload to preserve semantics while still dropping the non-const version.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Previously the const overload returned the QMultiMap by value, so changing it to a const reference is an observable API change for generated code (e.g., callers storing the map past the object's lifetime); if avoiding mutation is the goal, consider keeping the return-by-value const overload to preserve semantics while still dropping the non-const version.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
zccrs
approved these changes
May 27, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zccrs, zzxyb The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: Removed non-const resourceMap() to prevent unintended modification of internal resource tracking
Influence:
Summary by Sourcery
Enhancements: