Skip to content

test: cover member organization affiliations (CM-1180)#4327

Draft
skwowet wants to merge 8 commits into
test-kit-primitivesfrom
tests/CM-1180
Draft

test: cover member organization affiliations (CM-1180)#4327
skwowet wants to merge 8 commits into
test-kit-primitivesfrom
tests/CM-1180

Conversation

@skwowet

@skwowet skwowet commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
@skwowet skwowet self-assigned this Jul 12, 2026
Copilot AI review requested due to automatic review settings July 12, 2026 19:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds integration coverage for member organization affiliation timeline selection and activity refresh behavior.

Changes:

  • Tests timeline fallbacks, overrides, priorities, manual affiliations, and email domains.
  • Tests activity relation updates across timeline scenarios.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 13, 2026 07:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 13, 2026 08:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread services/libs/data-access-layer/src/member-organization-affiliation/index.test.ts Outdated
Comment thread services/libs/data-access-layer/src/member-organization-affiliation/index.test.ts Outdated
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 13, 2026 09:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread services/libs/data-access-layer/src/member-organization-affiliation/index.test.ts Outdated
Comment thread docs/adr/0008-how-we-write-unit-tests.md
skwowet added 2 commits July 13, 2026 15:48
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 13, 2026 10:19
@skwowet skwowet changed the title test: cover member organization affiliation refresh and timeline (CM-1180) test: cover member organization affiliations (CM-1180) Jul 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

Comment thread services/libs/data-access-layer/src/member-organization-affiliation/index.test.ts Outdated
Comment thread services/libs/data-access-layer/src/member-organization-affiliation/index.test.ts Outdated
Comment thread services/libs/data-access-layer/src/member-organization-affiliation/index.test.ts Outdated
Comment thread services/libs/data-access-layer/src/member-organization-affiliation/index.test.ts Outdated
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 13, 2026 11:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comment thread services/libs/data-access-layer/src/member-organization-affiliation/index.test.ts Outdated
Comment thread services/libs/data-access-layer/src/member-organization-affiliation/index.test.ts Outdated
Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 13, 2026 11:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

Comment on lines +572 to +575
expect(manualItems(timeline)).toHaveLength(0)
expect(baseItems(timeline).every((item) => item.skipManualAffiliationSegments === false)).toBe(
true,
)
Comment on lines +638 to +641
expect(manualItems(timeline)).toHaveLength(0)
expect(baseItems(timeline).every((item) => item.skipManualAffiliationSegments === false)).toBe(
true,
)
Comment on lines +702 to +716
expect(manual).toEqual(
expect.arrayContaining([
expect.objectContaining({
organizationId: sap.id,
dateStart: EPOCH,
segmentId: kubernetes.id,
}),
expect.objectContaining({
organizationId: orlix.id,
dateStart: EPOCH,
segmentId: harbor.id,
}),
]),
)
expect(manual).toHaveLength(2)
Comment on lines +1019 to +1021
expect(
baseItems(timeline).every((item) => item.excludeEmailDomains?.includes('redhat.com')),
).toBe(true)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants