-
Notifications
You must be signed in to change notification settings - Fork 335
fix(voice): disable AEC warmup for outbound SIP calls #2202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@livekit/agents': patch | ||
| --- | ||
|
|
||
| Disable the default AEC warmup for outbound SIP calls while preserving explicit settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Echo-cancellation warmup is not disabled for outbound phone calls when the caller is already in the room
The session is only told about the linked caller from the connect path (
this.agentSession._onRoomIOParticipantLinked(participant)atagents/src/voice/room_io/room_io.ts:262) and not from the path that switches to a caller that has already joined, so those outbound phone calls keep the 3-second interruption block.Impact: For outbound calls where the callee is already present when the agent focuses on them, early speech from the callee is still ignored during the greeting.
Two code paths resolve the linked participant, only one notifies the session
RoomIO.setParticipant()also resolvesparticipantAvailableFuturedirectly when the target participant is already inroom.remoteParticipants(agents/src/voice/room_io/room_io.ts:473-483) and never calls_onRoomIOParticipantLinked. This public method is the documented way to focus the session on a SIP callee (seeexamples/src/telephony_amd.ts:75). If the SIP participant is created beforesetParticipantis called, the linked-participant hook never runs andsessionOptions.aecWarmupDurationstays at the 3000 ms default even for an outbound SIP call, which is exactly the case this PR aims to fix.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is unclear why you would have another participant before a SIP call and have the callee waiting on the line? In that case, it is almost like an inbound call.