feat(deepgram): add numerals, profanity_filter, and redact options to STTv2 (Flux) - #6993
Open
vadimatmurphy wants to merge 2 commits into
Open
feat(deepgram): add numerals, profanity_filter, and redact options to STTv2 (Flux)#6993vadimatmurphy wants to merge 2 commits into
vadimatmurphy wants to merge 2 commits into
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
vadimatmurphy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6992
Adds
numerals,profanity_filter, andredactoptions toSTTv2, wired throughSTTOptions, bothupdate_optionspaths, and the websocket query string. Flux only accepts these at connection time (noConfiguretoggle), so changing any of them viaupdate_optionstriggers a reconnect instead of an in-bandConfiguremessage.redactis typed to the two values Flux accepts,numbersandaggressive_numbers; entity redaction (pci, pii, ...) is not supported by Flux.Verified against the live
/v2/listenendpoint: all three params are accepted at handshake (including through this plugin's connection path), while unsupported values and Nova-only params are rejected with HTTP 400. Docs: https://developers.deepgram.com/docs/numerals, https://developers.deepgram.com/docs/profanity-filter, https://developers.deepgram.com/docs/redactionThe query-string construction in
_connect_wsmoved into a_live_confighelper so tests can assert on it directly. Tests cover the reconnect behavior and the presence/absence of the new params in the connection config.Supersedes #6506 (closed unmerged, unsigned CLA).