fix(ipc): mark supervised processes dead for prometheus - #7017
Open
Ricky-7-Yan wants to merge 1 commit into
Open
fix(ipc): mark supervised processes dead for prometheus#7017Ricky-7-Yan wants to merge 1 commit into
Ricky-7-Yan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mark_process_dead(pid)after the supervised child is joined and before itsProcesshandle is closedThis intentionally does not implement wildcard deletion of every
*_<pid>.dbfile; that broader policy is separate fromprometheus_client's documented dead-process hook.Fixes #7006.
Testing
1 passedruff check livekit-agents/livekit/agents/ipc/supervised_proc.py tests/test_supervised_proc_memory.pyruff format --check livekit-agents/livekit/agents/ipc/supervised_proc.py tests/test_supervised_proc_memory.pypython -m py_compile livekit-agents/livekit/agents/ipc/supervised_proc.py tests/test_supervised_proc_memory.pygit diff --checkThe focused test used the current source and test files against the released
livekit-agents==1.7.1dependency set because GitHub's filtered blob transport was intermittently resetting on this Windows host.