Dispatch log batches off the main thread#266
Closed
MaxHeimbrock wants to merge 1 commit intomainfrom
Closed
Conversation
Logs from Rust were going through SynchronizationContext.Post like every other event, which is wasteful: UnityEngine.Debug.unityLogger is thread-safe, log batches are SDK-internal (no user callback expectation), and in LK_VERBOSE builds they can flood the post queue. Forward them inline from the FFI callback alongside AudioStreamEvent and remove the now-unreachable Logs case from DispatchEvent. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Done in: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logs from Rust were going through SynchronizationContext.Post like every other event, which is wasteful: UnityEngine.Debug.unityLogger is thread-safe, log batches are SDK-internal (no user callback expectation), and in LK_VERBOSE builds they can flood the post queue.
Forward them inline from the FFI callback alongside AudioStreamEvent and remove the now-unreachable Logs case from DispatchEvent.