feat(rpc/room): add ListParticipants and GetParticipant#1459
Open
sohbit wants to merge 1 commit intolivekit:mainfrom
Open
feat(rpc/room): add ListParticipants and GetParticipant#1459sohbit wants to merge 1 commit intolivekit:mainfrom
ListParticipants and GetParticipant#1459sohbit wants to merge 1 commit intolivekit:mainfrom
Conversation
Add `ListParticipants` and `GetParticipant` RPCs to the `Room` PSRPC service, following the same topic-based routing pattern as: - `DeleteRoom`, - `SendData`, - and `UpdateRoomMetadata`. These are needed so the livekit server can route participant read operations to the authoritative RTC node instead of reading from eventually-consistent Redis. No breaking changes for existing `UnimplementedRoomServer` embedders (new methods have default stubs).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add
ListParticipantsandGetParticipantRPCs to theRoomPSRPC service, following the same topic-based routing pattern as:DeleteRoom,SendData,UpdateRoomMetadata.These are needed so the livekit server can route participant read operations to the authoritative RTC node instead of reading from eventually-consistent Redis.
No breaking changes for existing
UnimplementedRoomServerembedders (new methods have default stubs).Dependencies
The following fix on
livekit/livekitexpects these changes: