Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions auth/verifier.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,14 @@ func (v *APIKeyTokenVerifier) Verify(key interface{}) (*jwt.Claims, *ClaimGrants
if key == nil || key == "" {
return nil, nil, ErrKeysMissing
}
// If a KeyProvider is passed, resolve it to the secret string for this token's API key.
if kp, ok := key.(KeyProvider); ok {
secret := kp.GetSecret(v.apiKey)
if secret == "" {
return nil, nil, ErrKeysMissing
}
key = []byte(secret)
}
if s, ok := key.(string); ok {
key = []byte(s)
}
Expand Down
37 changes: 37 additions & 0 deletions auth/verifier_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,43 @@ func TestVerifier(t *testing.T) {
require.EqualValues(t, attrs, decoded.Attributes)
})

t.Run("verify with KeyProvider", func(t *testing.T) {
claim := auth.VideoGrant{RoomJoin: true, Room: "testroom"}
at := auth.NewAccessToken(apiKey, secret).
SetVideoGrant(&claim).
SetValidFor(time.Minute).
SetIdentity("user1")
authToken, err := at.ToJWT()
require.NoError(t, err)

v, err := auth.ParseAPIToken(authToken)
require.NoError(t, err)

// Passing a SimpleKeyProvider directly should work.
provider := auth.NewSimpleKeyProvider(apiKey, secret)
_, decoded, err := v.Verify(provider)
require.NoError(t, err)
require.Equal(t, "user1", decoded.Identity)
require.Equal(t, &claim, decoded.Video)
})

t.Run("verify with KeyProvider wrong key returns error", func(t *testing.T) {
claim := auth.VideoGrant{RoomJoin: true}
at := auth.NewAccessToken(apiKey, secret).
SetVideoGrant(&claim).
SetValidFor(time.Minute)
authToken, err := at.ToJWT()
require.NoError(t, err)

v, err := auth.ParseAPIToken(authToken)
require.NoError(t, err)

// Provider with wrong key should fail.
provider := auth.NewSimpleKeyProvider("wrongkey", "wrongsecret")
_, _, err = v.Verify(provider)
require.Error(t, err)
})

t.Run("nil permissions are handled", func(t *testing.T) {
grant := &auth.VideoGrant{
Room: "myroom",
Expand Down
Loading