Mandate TDD with observable-behavior e2e tests in agent guidance - #445
Draft
skyrpex wants to merge 1 commit into
Draft
Mandate TDD with observable-behavior e2e tests in agent guidance#445skyrpex wants to merge 1 commit into
skyrpex wants to merge 1 commit into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
skyrpex
added
semver: patch
docs: skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Agent sessions were writing implementations first and backfilling tests. We want the opposite: every feature or fix starts from a failing end-to-end test.
Solution
Extends the Testing section in CLAUDE.md (AGENTS.md symlinks to it) with three rules: TDD is mandatory (red → green → refactor — write the e2e test, confirm it fails for the expected reason, then implement); e2e tests assert only observable behavior (exit codes, output, files, requests received), asking the user when the observable behavior is unclear; and observable mocks of external systems (mock auth endpoint, fake
aws/azon PATH, fake browser opener) are encouraged as the product boundary — never mocks of lstk internals. Also adds a matching checklist line to the/review-prskill so the rule is enforced at review time.Docs
Nothing to document — agent/contributor guidance only, no user-facing behavior change.
Review
Self-merge candidate — guidance-only change, no code touched, content was specified directly in the session.
Co-Authored-By: Claude noreply@anthropic.com