Skip to content

Document external pull requests contribution policy - #454

Open
gtsiolis wants to merge 1 commit into
mainfrom
pro-260-community-contribution-readiness
Open

Document external pull requests contribution policy#454
gtsiolis wants to merge 1 commit into
mainfrom
pro-260-community-contribution-readiness

Conversation

@gtsiolis

Copy link
Copy Markdown
Member

Motivation

Pull request creation is now restricted to collaborators (pull_request_creation_policy = collaborators_only), but the repo still tells external contributors to fork and open a PR — CONTRIBUTING's first PR step is literally "Fork the repository". Someone following it hits a wall with no explanation.

Solution

States the policy in CONTRIBUTING and README, and keeps the channel that is still open visible: issues, which is the external channel that actually gets used (3 of our 6 issues came from outside, versus 2 fork PRs in 446). Also drops the stale fork step, which was already wrong for us — everyone branches directly.

The wording says "not currently", so reopening later doesn't need a retraction.

Two follow-ups this deliberately leaves out:

  • No security reporting path. Private vulnerability reporting is disabled and there is no SECURITY.md here or in localstack/.github, so a reporter's only route is a public issue. Adding one needs the admin toggle enabled and security@localstack.cloud confirmed as an inbound mailbox first.
  • Labels. good first issue and help wanted have 0 uses ever and are not in the synced manifest, so they can be deleted. community contribution should stay — feat(config): add LogDir and move diagnostic logs to XDG state #192 and Add doctor command for environment checks #184 carry it.
Docs

Nothing to document. The change is to the repository's own CONTRIBUTING and README; the lstk docs site has no contributing section.

Review

Please review. This is user-facing policy text on the repo's front door, and the contribution policy was going to be raised at Monday's DevX sync — worth landing the wording with the team rather than self-merging.

Towards PRO-260

Co-Authored-By: Claude noreply@anthropic.com

@gtsiolis
gtsiolis requested review from a team and peter-smith-phd as code owners August 12, 2026 17:13
@gtsiolis gtsiolis added semver: patch docs: skip Pull request does not require documentation changes labels Aug 12, 2026
@gtsiolis gtsiolis self-assigned this Aug 12, 2026
Co-Authored-By: Claude <noreply@anthropic.com>
@gtsiolis
gtsiolis force-pushed the pro-260-community-contribution-readiness branch from f55ceb5 to b04e7f1 Compare August 12, 2026 17:15
@gtsiolis

Copy link
Copy Markdown
Member Author

Cc @anisaoshafi because of relevant discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs: skip Pull request does not require documentation changes semver: patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant