Skip to content

GRS80 should be recognized as a WGS84 transformation type#127

Merged
pomadchin merged 5 commits intolocationtech:masterfrom
AndreasWBartels:BUG125
Apr 27, 2026
Merged

GRS80 should be recognized as a WGS84 transformation type#127
pomadchin merged 5 commits intolocationtech:masterfrom
AndreasWBartels:BUG125

Conversation

@AndreasWBartels
Copy link
Copy Markdown
Contributor

@AndreasWBartels AndreasWBartels commented Apr 27, 2026

Fix #125

@AndreasWBartels
Fix for transform type WGS84 derection
e82e808 
Signed-off-by: bartels <andreas.bartels@disy.net>
@AndreasWBartels
Fix for datumshift skip
630b3f8 
Signed-off-by: bartels <andreas.bartels@disy.net>
@AndreasWBartels
Removed not needed imports
1dffad7 
Signed-off-by: bartels <andreas.bartels@disy.net>
@AndreasWBartels
Revert "Fix for datumshift skip"
641adfd 
This reverts commit 630b3f8.
@AndreasWBartels
Revert "Removed not needed imports"
6cecbac 
This reverts commit 1dffad7.
@pomadchin
Copy link
Copy Markdown
Member

pomadchin commented Apr 27, 2026 •
edited
Loading

Thanks for rising up a PR, really appreciate it!

Also could I ask you to sign https://www.eclipse.org/legal/eca/? (ECA form link) that would help us to make the ECA bot happy!

@AndreasWBartels AndreasWBartels marked this pull request as ready for review April 27, 2026 15:53
@AndreasWBartels
Copy link
Copy Markdown
Contributor Author

AndreasWBartels commented Apr 27, 2026

If the pull is done with squashing the code for the bug 126 should be ignored

@pomadchin pomadchin changed the title Bug125 GRS80 should be recognized as a WGS84 transformation type Apr 27, 2026
@pomadchin
Copy link
Copy Markdown
Member

pomadchin commented Apr 27, 2026 •
edited
Loading

Thank you so much! Also GZ with the first contribution! 🎉

@pomadchin pomadchin merged commit 057bcde into locationtech:master Apr 27, 2026
2 checks passed
AndreasWBartels added a commit to AndreasWBartels/proj4j that referenced this pull request Apr 29, 2026
@AndreasWBartels
GRS80 should be recognized as a WGS84 transformation type (locationte…
6826aca 
…ch#127) (#2)

* Fix for transform type WGS84 derection

Signed-off-by: bartels <andreas.bartels@disy.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Detection of the WGS84 transformation type is not working

2 participants

@AndreasWBartels @pomadchin