fix: add values to enum type#598
Open
aaqilniz wants to merge 1 commit into
Open
Conversation
aaqilniz
force-pushed
the
fix/enum-values
branch
2 times, most recently
from
August 24, 2024 20:29
0a3f60f to
d47460c
Compare
Signed-off-by: Muhammad Aaqil <aaqilcs102@gmail.com>
aaqilniz
force-pushed
the
fix/enum-values
branch
from
August 25, 2024 06:47
608b7ba to
a8d0445
Compare
aaqilniz
marked this pull request as ready for review
August 25, 2024 17:48
Contributor
Author
|
Hi, @dhmlau. One of the tests is failing for some reason. There is no direct/indirect change to the failing test case. I tried for a while but can't figure it out. Can you please have a look whenever you have the chance? |
Collaborator
It seems like your changes to migration.js may have caused it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpasses on your machine