ci: migrate to pure ghactions deploy; harden runner#2049
Merged
Conversation
achrinza
force-pushed
the
ci/migrate-to-pure-ghactions-deploy
branch
from
c66848d to
b3d0afa
Compare
This was referenced Jul 8, 2026
This moves away from the compatibility setup which simulates Pages Legacy Worker workflow. This simplifies the setup, since the compat layer still converges to the same deployment strategy. Furthermore, we can remove dependency on the external GH Action with long-lived SSH credentials closes: #2048 Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com>
see: loopbackio/security#26 Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com>
achrinza
force-pushed
the
ci/migrate-to-pure-ghactions-deploy
branch
from
b3d0afa to
f0b2ef4
Compare
Member
Author
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This moves away from the compatibility setup which simulates Pages Legacy Worker workflow.
This simplifies the setup, since it's no longer pegged to old dependencies via the
github-pagesgem.Feature-wise is the same; The compat layer still ends up using to the same GitHub Actions-style deployment strategy anyways.
Furthermore, we can remove dependency on the external GitHub Action with long-lived SSH credentials.
This also hardens the runner.
Testing
These changes have been tested on a fork: achrinzafork@ce0098d, with a slight deviation of adding
rubygems.org:443intoallowed-endpointsfor Ruby cache misses.Before Merging
Reconfigure GitHub Pages deployment method to from
Deploy from a branchtoGitHub ActionsIf we don't change this, GitHub will auto-deploy a workflow alongside this workflow, and the last one to complete will override the first one.
After merging
DEPLOY_KEYGitHub Actions secretDEPLOY_KEYfrom this repocloses: #2048
see: loopbackio/security#26