Review fixes

.github/workflows/ci.yml

@@ -6,27 +6,72 @@ on:
     tags: ['v*']
   pull_request:
   workflow_dispatch:
-    inputs:
-      tag:
-        description: 'Tag to create and release (e.g. v0.1.0)'
-        required: true
-        type: string
 
 env:
   CARGO_TERM_COLOR: always
   CARGO_INCREMENTAL: 0
 
 jobs:
-  # ── Tests ─────────────────────────────────────────────────────────────
+  # ── Tests + lints ─────────────────────────────────────────────────────
   # Runs on every push and PR. Gates the release.
   test:
     name: Test
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@stable
+        with:
+          components: rustfmt, clippy
+      - uses: Swatinem/rust-cache@v2
+      - run: cargo fmt --all --check
+      - run: cargo clippy -p pixfix --all-targets --features tui -- -D warnings
+      - run: cargo test --locked --features tui
+
+  # ── Coverage ──────────────────────────────────────────────────────────
+  # cargo-llvm-cov over the CLI crate (pixfix needs a GUI stack and has no
+  # tests). Upload failures don't fail CI — coverage is a signal, not a gate.
+  coverage:
+    name: Coverage
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@stable
+        with:
+          components: llvm-tools-preview
+      - uses: taiki-e/install-action@cargo-llvm-cov
       - uses: Swatinem/rust-cache@v2
-      - run: cargo test --locked
+        with:
+          key: coverage
+      - run: cargo llvm-cov -p pixfix --features tui --locked --lcov --output-path lcov.info
+      - uses: codecov/codecov-action@v5
+        with:
+          files: lcov.info
+          token: ${{ secrets.CODECOV_TOKEN }}
+          fail_ci_if_error: false
+
+  # ── pixfix compile check ──────────────────────────────────────────────
+  # The desktop app is a workspace member the root test job never builds;
+  # without this, PRs cannot catch desktop-app breakage.
+  check-pixfix:
+    name: Check pixfix
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@stable
+        with:
+          components: clippy
+      - uses: Swatinem/rust-cache@v2
+        with:
+          key: desktop-check
+      - name: Install Linux dependencies
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y \
+            libgtk-3-dev \
+            libwebkit2gtk-4.1-dev \
+            libappindicator3-dev \
+            librsvg2-dev
+      - run: cargo clippy -p pixfix-desktop --all-targets --locked -- -D warnings
 
   # ── CLI binaries ──────────────────────────────────────────────────────
   # Pure Rust, no system deps. Runs on push to master, tags, and manual dispatch.
@@ -58,23 +103,27 @@ jobs:
         if: runner.os != 'Windows'
         run: |
           cd target/${{ matrix.target }}/release
-          tar czf "$GITHUB_WORKSPACE/normalize-pixelart-${{ matrix.name }}.tar.gz" normalize-pixelart
+          tar czf "$GITHUB_WORKSPACE/pixfix-${{ matrix.name }}.tar.gz" pixfix
 
       - name: Package (Windows)
         if: runner.os == 'Windows'
         shell: bash
         run: |
           cd target/${{ matrix.target }}/release
-          7z a "$GITHUB_WORKSPACE/normalize-pixelart-${{ matrix.name }}.zip" normalize-pixelart.exe
+          7z a "$GITHUB_WORKSPACE/pixfix-${{ matrix.name }}.zip" pixfix.exe
 
       - uses: actions/upload-artifact@v4
         with:
           name: cli-${{ matrix.name }}
-          path: normalize-pixelart-${{ matrix.name }}.*
+          path: pixfix-${{ matrix.name }}.*
           if-no-files-found: error
 
   # ── Tauri desktop app ─────────────────────────────────────────────────
   # Needs system libs on Linux, bun for frontend, Tauri CLI for bundling.
+  # The frontend bundle is built by tauri.conf.json's beforeBuildCommand;
+  # Tauri executes hooks from the cargo workspace root, hence the
+  # repo-root-relative paths in the config. No separate frontend step or
+  # config override needed.
   build-tauri:
     name: Tauri / ${{ matrix.name }}
     if: github.event_name == 'push' || github.event_name == 'workflow_dispatch'
@@ -108,17 +157,13 @@ jobs:
             librsvg2-dev \
             patchelf
 
-      - name: Build frontend
-        run: bun build pixfix/ui/src/app.ts --outfile pixfix/ui/app.js --minify
-
       - name: Build Tauri app
         shell: bash
-        working-directory: pixfix
+        working-directory: desktop
         run: |
           bunx @tauri-apps/cli@^2 build \
             --target ${{ matrix.target }} \
-            --bundles ${{ matrix.bundles }} \
-            --config '{"build":{"beforeBuildCommand":""}}'
+            --bundles ${{ matrix.bundles }}
 
       - name: Collect bundles
         shell: bash
@@ -136,31 +181,40 @@ jobs:
           path: dist/*
           if-no-files-found: error
 
+  # ── crates.io ─────────────────────────────────────────────────────────
+  # Publishes the CLI crate on version tags. Skips quietly when the
+  # CARGO_REGISTRY_TOKEN secret is not configured.
+  publish-crate:
+    name: Publish to crates.io
+    if: startsWith(github.ref, 'refs/tags/v')
+    needs: [test, check-pixfix]
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@stable
+      - name: Publish
+        env:
+          CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }}
+        run: |
+          if [ -z "$CARGO_REGISTRY_TOKEN" ]; then
+            echo "CARGO_REGISTRY_TOKEN not set; skipping crates.io publish"
+            exit 0
+          fi
+          cargo publish -p pixfix --locked
+
   # ── GitHub Release ────────────────────────────────────────────────────
-  # Runs on version tags or manual dispatch with a tag input.
+  # Tag pushes release automatically; manual re-releases from an existing
+  # CI run live in release.yml (the only other release path).
   release:
     name: Release
-    if: startsWith(github.ref, 'refs/tags/v') || (github.event_name == 'workflow_dispatch' && inputs.tag != '')
-    needs: [test, build-cli, build-tauri]
+    if: startsWith(github.ref, 'refs/tags/v')
+    needs: [test, check-pixfix, build-cli, build-tauri]
     runs-on: ubuntu-latest
     permissions:
       contents: write
     steps:
       - uses: actions/checkout@v4
 
-      - name: Create and push tag
-        if: github.event_name == 'workflow_dispatch'
-        env:
-          GH_TOKEN: ${{ github.token }}
-        run: |
-          TAG="${{ inputs.tag }}"
-          if git ls-remote --tags origin | grep -q "refs/tags/$TAG$"; then
-            echo "Tag $TAG already exists on remote, skipping creation"
-          else
-            git tag "$TAG"
-            git push origin "$TAG"
-          fi
-
       - uses: actions/download-artifact@v4
         with:
           path: artifacts
@@ -173,7 +227,6 @@ jobs:
         env:
           GH_TOKEN: ${{ github.token }}
         run: |
-          TAG="${{ inputs.tag || github.ref_name }}"
-          gh release create "$TAG" artifacts/* \
+          gh release create "${{ github.ref_name }}" artifacts/* \
             --generate-notes \
-            --title "$TAG"
+            --title "${{ github.ref_name }}"

.github/workflows/docs.yml

@@ -0,0 +1,35 @@
+name: Docs
+
+on:
+  push:
+    branches: [master]
+    paths: ['docs/**', '.github/workflows/docs.yml']
+  workflow_dispatch:
+
+permissions:
+  contents: read
+  pages: write
+  id-token: write
+
+concurrency:
+  group: pages
+  cancel-in-progress: true
+
+jobs:
+  deploy:
+    name: Deploy to GitHub Pages
+    runs-on: ubuntu-latest
+    environment:
+      name: github-pages
+      url: ${{ steps.deployment.outputs.page_url }}
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/configure-pages@v5
+      # docs/ is deployed as-is: the wasm demo bundle (docs/demo/pkg) is
+      # prebuilt and committed. Regenerate with:
+      #   wasm-pack build wasm --target web --release --out-dir ../docs/demo/pkg
+      - uses: actions/upload-pages-artifact@v3
+        with:
+          path: docs
+      - id: deployment
+        uses: actions/deploy-pages@v4

.gitignore

@@ -16,7 +16,7 @@ test_images/
 !screenshots/**
 
 # Allow Tauri app icons
-!pixfix/icons/**
+!desktop/icons/**
 
 # Editor
 *.swp
@@ -25,3 +25,9 @@ test_images/
 
 # macOS
 .DS_Store
+
+# Built frontend bundle (bun build output; CI and tauri hooks rebuild it)
+desktop/ui/app.js
+
+# Real-image regression corpus is tracked despite the global image ignore
+!tests/corpus/*.png