Skip to content

Fix Email Logs API multi-value filters query string to use brackets notation#118

Merged
mklocek merged 1 commit intomainfrom
email-logs-filters-fix
Mar 17, 2026
Merged

Fix Email Logs API multi-value filters query string to use brackets notation#118
mklocek merged 1 commit intomainfrom
email-logs-filters-fix

Conversation

@mklocek
Copy link
Contributor

@mklocek mklocek commented Mar 15, 2026

Changes

  • Fix Email Logs API multi-value filters query string to use brackets notation

Summary by CodeRabbit

  • Bug Fixes
    • Updated array-valued filter parameter serialization for email logs to use bracket notation in query strings, ensuring consistent and correct formatting of multi-value filters.

@coderabbitai
Copy link

coderabbitai bot commented Mar 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a1d1e35e-e0b2-4a72-b702-6ccc865552b9

📥 Commits

Reviewing files that changed from the base of the PR and between 50e892d and fe472a4.

📒 Files selected for processing (2)
  • src/__tests__/lib/api/resources/EmailLogs.test.ts
  • src/lib/api/resources/EmailLogs.ts

📝 Walkthrough

Walkthrough

The EmailLogs API resource is updated to change array-valued query parameter serialization from "repeat" format to "brackets" format. Query parameters now serialize with empty bracket notation (e.g., value[]=item). The test expectations are correspondingly updated to verify the new serialization behavior.

Changes

Cohort / File(s) Summary
EmailLogs Resource & Tests
src/lib/api/resources/EmailLogs.ts, src/__tests__/lib/api/resources/EmailLogs.test.ts
Updated array parameter serialization strategy from "repeat" to "brackets" format in qs.stringify configuration, with corresponding test expectations adjusted to verify the new bracket-style query encoding for array-valued filters.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • leonid-shevtsov
  • piobeny
  • IgorDobryn

Poem

🐰 Hops of joy for brackets bright,
Arrays serialize just right,
value[]= now takes the stage,
Tests updated, turn the page!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is incomplete and lacks essential context. Only the 'Changes' section is minimally filled; required sections like 'Motivation', 'How to test', and 'Images and GIFs' are entirely missing. Add 'Motivation' section explaining why brackets notation is needed, complete 'How to test' with specific test steps, and fill other template sections as applicable.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating Email Logs API filters to use brackets notation for multi-value query strings.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch email-logs-filters-fix
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mklocek mklocek requested a review from VladimirTaytor March 17, 2026 07:24
@mklocek mklocek merged commit 63a8586 into main Mar 17, 2026
4 checks passed
@mklocek mklocek deleted the email-logs-filters-fix branch March 17, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants