fix (makeen-user): make passport.deserializeUser async#10
Open
redbmk wants to merge 1 commit intomakeen-project:masterfrom
Open
fix (makeen-user): make passport.deserializeUser async#10redbmk wants to merge 1 commit intomakeen-project:masterfrom
redbmk wants to merge 1 commit intomakeen-project:masterfrom
Conversation
deserializeUser should not try to use the UserRepository service without waiting for it
viczam
reviewed
Nov 2, 2017
| .findById(objectId(id)) | ||
| .then(user => cb(null, user), cb); | ||
| passport.deserializeUser(async (req, id, cb) => { | ||
| const { UserRepository } = await req.app.modules.get('makeen.user'); |
Contributor
There was a problem hiding this comment.
no need for that - modules.get('some-module-name') is synchronous and it returns a map of that module's exports
Author
|
That's odd. I was getting this error in my project that's just using the basic |
Contributor
|
That is weird. Are you using this exact module or a modified version of it? |
Author
|
Just the vanilla module, v1.8.11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deserializeUser should not try to use
the UserRepository service without waiting for it