[INFRA-372]: Add Plane-EE Helm chart configuration for PostgreSQL read replica support#222
[INFRA-372]: Add Plane-EE Helm chart configuration for PostgreSQL read replica support#222pratapalakshmi wants to merge 3 commits intomasterfrom
Conversation
…eplica support - Updated `Chart.yaml` to version 2.3.3. - Added `DATABASE_READ_REPLICA_URL` to `app-env.yaml` for conditional inclusion based on values. - Introduced `read_replica` configuration in `values.yaml` for PostgreSQL service.
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughBumps the Plane Enterprise Helm chart version to 2.3.3 and introduces PostgreSQL read replica support by adding configuration values and environment variable wiring to the application deployment templates. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
charts/plane-enterprise/templates/config-secrets/app-env.yaml (1)
28-30: Consider documenting that read-replica is remote-only.Unlike the
DATABASE_URLblock (Lines 20-26) which derives a URL from the in-cluster service whenlocal_setup=true, the new block has nolocal_setupbranch — read-replica only works when an explicitremote_urlis supplied. That seems intentional (in-cluster single-node Postgres can't serve as its own replica), but it's worth a short comment invalues.yamlnext toread_replica.remote_urlto set operator expectations.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@charts/plane-enterprise/templates/config-secrets/app-env.yaml` around lines 28 - 30, Add a short clarifying comment in values.yaml next to the services.postgres.read_replica.remote_url key stating that read-replica is remote-only (the chart/template only sets DATABASE_READ_REPLICA_URL when remote_url is provided and does not derive an in-cluster URL even with local_setup=true); reference the values key services.postgres.read_replica.remote_url and the template output variable DATABASE_READ_REPLICA_URL so operators understand they must supply a remote URL for replicas.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@charts/plane-enterprise/templates/config-secrets/app-env.yaml`:
- Around line 28-30: Guard against enabled=true with an empty remote_url by
updating the template that emits DATABASE_READ_REPLICA_URL: check
.Values.services.postgres.read_replica.enabled and
.Values.services.postgres.read_replica.remote_url together: either only render
DATABASE_READ_REPLICA_URL when remote_url is non-empty, or add a fail-fast check
(e.g. {{- if and .Values.services.postgres.read_replica.enabled (not
.Values.services.postgres.read_replica.remote_url) }}{{ fail
"read_replica.enabled is true but read_replica.remote_url is empty" }}{{- end
}}) to stop chart rendering; ensure this is coordinated with ENABLE_READ_REPLICA
so the ConfigMap and Secret remain consistent (refer to
.Values.services.postgres.read_replica.enabled,
.Values.services.postgres.read_replica.remote_url, DATABASE_READ_REPLICA_URL and
ENABLE_READ_REPLICA).
In `@charts/plane-enterprise/values.yaml`:
- Around line 84-86: The inline comment on the remote_url entry under
read_replica contains trailing whitespace; edit the values for
read_replica.remote_url to remove the extra spaces after "URL ONLY" so the
comment ends immediately after the text (ensure symbol names: read_replica and
remote_url remain unchanged).
---
Nitpick comments:
In `@charts/plane-enterprise/templates/config-secrets/app-env.yaml`:
- Around line 28-30: Add a short clarifying comment in values.yaml next to the
services.postgres.read_replica.remote_url key stating that read-replica is
remote-only (the chart/template only sets DATABASE_READ_REPLICA_URL when
remote_url is provided and does not derive an in-cluster URL even with
local_setup=true); reference the values key
services.postgres.read_replica.remote_url and the template output variable
DATABASE_READ_REPLICA_URL so operators understand they must supply a remote URL
for replicas.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6e4fe427-4e0c-4586-9d92-0fae4932f121
📒 Files selected for processing (3)
charts/plane-enterprise/Chart.yamlcharts/plane-enterprise/templates/config-secrets/app-env.yamlcharts/plane-enterprise/values.yaml
pratapalakshmi
changed the title
|
Linked to Plane Work Item(s) This comment was auto-generated by Plane |
pratapalakshmi
changed the title
1 participant
Summary by CodeRabbit
New Features
Chores