fix: handle compact JSON in checkLatestRelease()#8911
fix: handle compact JSON in checkLatestRelease()#8911avasis-ai wants to merge 1 commit intomakeplane:masterfrom
Conversation
|
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Can we merge this? I'm pretty sure many users can't upgrade their Plane because of this and possibly break something else while trying to solve the problem. |
Summary
Fixes #8775
The
checkLatestRelease()function usesgrepto extracttag_namefrom the GitHub API response. The current pattern'"tag_name": "[^"]*"'assumes a space after the colon, but the GitHub API sometimes returns compact JSON without spaces ("tag_name":"v1.2.3"), causing the grep to match nothing and the script to exit with an error.Changes
grepandsedpatterns using[ ]*(zero or more spaces)deployments/cli/community/install.shanddeployments/swarm/community/swarm.shTest plan
./setup.shand select Option 5 (Upgrade)