fix: add logger_task to CELERY_IMPORTS so process_logs is registered in worker#8929
fix: add logger_task to CELERY_IMPORTS so process_logs is registered in worker#8929vdaluz wants to merge 1 commit intomakeplane:previewfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA single configuration entry Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #8928
What
Adds
plane.bgtasks.logger_tasktoCELERY_IMPORTSinplane/settings/common.py.Why
logger_task.pywas introduced in #8245 with a@shared_taskdecorator, but was never added toCELERY_IMPORTS. The Celery worker only imports modules listed there, soprocess_logsis never registered. Every API request queues this task (viaAPITokenLogMiddleware) and the worker discards it with:This silently breaks API activity logging and floods worker logs with errors.
Change
CELERY_IMPORTS = ( ... # issue version tasks "plane.bgtasks.issue_version_sync", "plane.bgtasks.issue_description_version_sync", + # API activity logging + "plane.bgtasks.logger_task", )One line added. No other changes.
Summary by CodeRabbit