Skip to content

fix: dispatch() error handler returns exc instead of response #8933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MinitJain wants to merge 1 commit into
base: preview
Choose a base branch
from
+6 −6
Open

fix: dispatch() error handler returns exc instead of response #8933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/api/plane/api/views/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def dispatch(self, request, *args, **kwargs):
return response
except Exception as exc:
response = self.handle_exception(exc)
return exc
return response

def finalize_response(self, request, response, *args, **kwargs):
# Call super to get the default response
Expand Down
4 changes: 2 additions & 2 deletions apps/api/plane/app/views/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def dispatch(self, request, *args, **kwargs):
return response
except Exception as exc:
response = self.handle_exception(exc)
return exc
return response

@property
def workspace_slug(self):
Expand Down Expand Up @@ -215,7 +215,7 @@ def dispatch(self, request, *args, **kwargs):

except Exception as exc:
response = self.handle_exception(exc)
return exc
return response

@property
def workspace_slug(self):
Expand Down
2 changes: 1 addition & 1 deletion apps/api/plane/license/api/views/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def dispatch(self, request, *args, **kwargs):

except Exception as exc:
response = self.handle_exception(exc)
return exc
return response

@property
def fields(self):
Expand Down
4 changes: 2 additions & 2 deletions apps/api/plane/space/views/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def dispatch(self, request, *args, **kwargs):
return response
except Exception as exc:
response = self.handle_exception(exc)
return exc
return response

@property
def workspace_slug(self):
Expand Down Expand Up @@ -197,7 +197,7 @@ def dispatch(self, request, *args, **kwargs):

except Exception as exc:
response = self.handle_exception(exc)
return exc
return response

@property
def workspace_slug(self):
Expand Down