fix: SMTPEmailBackend with optional SSL hostname verification bypass#8972
Open
ericmaster wants to merge 1 commit intomakeplane:developfrom
Open
fix: SMTPEmailBackend with optional SSL hostname verification bypass#8972ericmaster wants to merge 1 commit intomakeplane:developfrom
ericmaster wants to merge 1 commit intomakeplane:developfrom
Conversation
This adds a custom SMTP email backend that allows disabling SSL hostname verification for SMTP providers whose certificates don't match the DNS hostname. Brevo/Sendinblue uses load-balanced SMTP servers with certificates issued for regional hostnames (e.g. smtp-relay-offshore-southamerica-east-v2.sendinblue.com) that differ from the public DNS name (smtp-relay.brevo.com), causing: ssl.SSLCertVerificationError: Hostname mismatch The fix adds plane.utils.email_backend.SMTPEmailBackend which sets check_hostname=False and verify_mode=CERT_NONE on the SSL context. Default EMAIL_BACKEND is now plane.utils.email_backend.SMTPEmailBackend but can be overridden via EMAIL_BACKEND environment variable. Fixes makeplane#8971
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes SMTP email configuration failures with providers like Brevo/Sendinblue whose SSL certificates don't match the DNS hostname.
Problem
When configuring SMTP in self-hosted Plane with Brevo, the email credentials test always fails with a 400 error because:
Python's SSL stack rejects this with:
ssl.SSLCertVerificationError: certificate verify failed: Hostname mismatch
Solution
Added plane.utils.email_backend.SMTPEmailBackend - a custom SMTP backend that disables SSL hostname verification by setting check_hostname=False and verify_mode=ssl.CERT_NONE.
Default EMAIL_BACKEND changed from Django's default to plane.utils.email_backend.SMTPEmailBackend. Can be overridden via EMAIL_BACKEND env var.
Changes
Testing
The fix was tested locally with Brevo SMTP and email sending works correctly.
Fixes
Fixes #8971