fix: prevent comment submission during IME composition#8982
fix: prevent comment submission during IME composition#8982717986230 wants to merge 2 commits intomakeplane:previewfrom
Conversation
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo comment submission components have been updated to prevent premature form submission when using IME (Input Method Editor) text composition. The changes add a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 6/8 reviews remaining, refill in 13 minutes and 6 seconds.Comment |
Summary
Prevents comments from being submitted while an IME composition is in progress.
Changes
e.nativeEvent.isComposingbefore submitting a new comment with Enter.e.nativeEvent.isComposingbefore submitting an edited comment with Enter.onKeyDownhandlers andLiteTextEditoronEnterKeyPresshandlers.Why
When typing Chinese or other IME-based text, pressing Enter can be used to confirm the current composition. Without checking
isComposing, the comment can be submitted unexpectedly before the user finishes typing.Related Issue
Closes #8913
Summary by CodeRabbit