Fix for an issue that caused WeekStartDay to fail while initializing Region #786
Open
Vignesh-Thangamariappan wants to merge 3 commits intomalcommac:masterfrom
Open
Fix for an issue that caused WeekStartDay to fail while initializing Region #786Vignesh-Thangamariappan wants to merge 3 commits intomalcommac:masterfrom
Vignesh-Thangamariappan wants to merge 3 commits intomalcommac:masterfrom
Conversation
added 2 commits
January 12, 2021 15:29
Updated the Region initialiser as firstWeekday is getting reset on setting the locale
|
@malcommac this seems like a valid fix for a valid bug. Can we merge it? @Vignesh-Thangamariappan can you rebase? |
|
Or return back this method? 4.5.1...5.0.0#diff-4ddb0e769834923d6d637cfe9c9974c5d6d2c0e17c1703ac9ec3b7eaae5f68a9L89-L96 |
Author
|
Sure @ExtremeMan |
Author
|
@malcommac Can you please review and merge these changes. Would be helpful for people facing #690 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #690