Skip to content

fix: remove void union from zoom/pitch events types #13600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GeoDaoyu wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −7
Open

fix: remove void union from zoom/pitch events types #13600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/ui/events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -982,7 +982,7 @@ export type MapEvents = {
* console.log('A zoomstart event occurred.');
* });
*/
'zoomstart': {originalEvent?: WheelEvent | TouchEvent} | void;
'zoomstart': {originalEvent?: WheelEvent | TouchEvent};

/**
* Fired repeatedly during an animated transition from one zoom level to another,
Expand All @@ -1002,7 +1002,7 @@ export type MapEvents = {
* });
* @see [Example: Update a choropleth layer by zoom level](https://www.mapbox.com/mapbox-gl-js/example/updating-choropleth/)
*/
'zoom': {originalEvent?: WheelEvent | TouchEvent} | void;
'zoom': {originalEvent?: WheelEvent | TouchEvent};

/**
* Fired just after the map completes a transition from one zoom level to another
Expand All @@ -1023,7 +1023,7 @@ export type MapEvents = {
* console.log('A zoomend event occurred.');
* });
*/
'zoomend': {originalEvent?: WheelEvent | TouchEvent} | void;
'zoomend': {originalEvent?: WheelEvent | TouchEvent};

/**
* Fired when a "drag to rotate" interaction starts. See {@link DragRotateHandler}.
Expand Down Expand Up @@ -1096,7 +1096,7 @@ export type MapEvents = {
* console.log('A pitchstart event occurred.');
* });
*/
'pitchstart': {originalEvent?: MouseEvent | TouchEvent} | void;
'pitchstart': {originalEvent?: MouseEvent | TouchEvent};

/**
* Fired repeatedly during the map's pitch (tilt) animation between
Expand All @@ -1116,7 +1116,7 @@ export type MapEvents = {
* console.log('A pitch event occurred.');
* });
*/
'pitch': {originalEvent?: MouseEvent | TouchEvent} | void;
'pitch': {originalEvent?: MouseEvent | TouchEvent};

/**
* Fired immediately after the map's pitch (tilt) finishes changing as
Expand All @@ -1135,7 +1135,7 @@ export type MapEvents = {
* console.log('A pitchend event occurred.');
* });
*/
'pitchend': {originalEvent?: MouseEvent | TouchEvent} | void;
'pitchend': {originalEvent?: MouseEvent | TouchEvent};

/**
* Fired when a "box zoom" interaction starts. See {@link BoxZoomHandler}.
Expand Down Expand Up @@ -1207,7 +1207,7 @@ export type MapEvents = {
* console.log('A resize event occurred.');
* });
*/
'resize': object | void;
'resize': object;

/** @section Lifecycle */

Expand Down